From: Paolo Bonzini <pbonzini@redhat.com>
To: Space Meyer <spm@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kpsingh@kernel.org
Subject: Re: [PATCH] KVM: Deal with nested sleeps in kvm_vcpu_block()
Date: Fri, 2 Dec 2022 19:26:59 +0100 [thread overview]
Message-ID: <8e8217f6-4eec-4793-637d-436a429c9aad@redhat.com> (raw)
In-Reply-To: <CAOLenvZm4aPJAv5O+iybMxJoD-ZeytbJ=9o1nLVSh+84uj2U8g@mail.gmail.com>
On 12/2/22 16:52, Space Meyer wrote:
> The bug doesn't seem to be easily reproducible, but looking at the
> code this should also be applicable for the upstream 6.0, 5.15, 5.10,
> 5.4, 4.19 and 4.14 branches, which have not received a backport of
> 26844fe.
>
> Do you think this is all we should do? My conclusion from the LWN
> article was, that we should avoid the set_current_state ->
> conditional -> schedule pattern when possible as well.
Yes, the bug is there but unfortunately the backport is not easy. I
don't really feel confident backporting the fix to older kernels; even
if it is apparently just a couple lines of code, event handling is very
delicate and has had a lot of changes recently.
Paolo
next prev parent reply other threads:[~2022-12-02 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 16:19 Space Meyer
2022-11-30 16:48 ` Paolo Bonzini
2022-12-02 15:52 ` Space Meyer
2022-12-02 18:26 ` Paolo Bonzini [this message]
2022-11-30 16:58 ` Paolo Bonzini
2022-12-02 15:52 ` Space Meyer
2022-12-02 18:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8217f6-4eec-4793-637d-436a429c9aad@redhat.com \
--to=pbonzini@redhat.com \
--cc=kpsingh@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®