* [PATCH] fix time ordering of writes to .kconfig.d and include/linux/autoconf.h
@ 2006-03-09 13:47 Jan Beulich
2006-03-12 22:43 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2006-03-09 13:47 UTC (permalink / raw)
To: sam; +Cc: linux-kernel
Since .kconfig.d is used as a make dependency of include/linux/autoconf.h, it
should be written earlier than the header file, to avoid a subsequent rebuild
to consider the header outdated.
Signed-Off-By: Jan Beulich <jbeulich@novell.com>
diff -Npru /home/jbeulich/tmp/linux-2.6.16-rc5/scripts/kconfig/confdata.c
2.6.16-rc5-kconfig_d-deps/scripts/kconfig/confdata.c
--- /home/jbeulich/tmp/linux-2.6.16-rc5/scripts/kconfig/confdata.c 2006-02-28 08:41:04.000000000 +0100
+++ 2.6.16-rc5-kconfig_d-deps/scripts/kconfig/confdata.c 2006-03-09 13:35:25.000000000 +0100
@@ -374,6 +374,7 @@ int conf_write(const char *name)
out_h = fopen(".tmpconfig.h", "w");
if (!out_h)
return 1;
+ file_write_dep(NULL);
}
sym = sym_lookup("KERNELVERSION", 0);
sym_calc_value(sym);
@@ -512,7 +513,6 @@ int conf_write(const char *name)
if (out_h) {
fclose(out_h);
rename(".tmpconfig.h", "include/linux/autoconf.h");
- file_write_dep(NULL);
}
if (!name || basename != conf_def_filename) {
if (!name)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fix time ordering of writes to .kconfig.d and include/linux/autoconf.h
2006-03-09 13:47 [PATCH] fix time ordering of writes to .kconfig.d and include/linux/autoconf.h Jan Beulich
@ 2006-03-12 22:43 ` Sam Ravnborg
2006-03-13 8:03 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2006-03-12 22:43 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-kernel
On Thu, Mar 09, 2006 at 02:47:46PM +0100, Jan Beulich wrote:
> Since .kconfig.d is used as a make dependency of include/linux/autoconf.h, it
> should be written earlier than the header file, to avoid a subsequent rebuild
> to consider the header outdated.
Thanks Jan. I assume you saw this in reality?
Applied.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix time ordering of writes to .kconfig.d and include/linux/autoconf.h
2006-03-12 22:43 ` Sam Ravnborg
@ 2006-03-13 8:03 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2006-03-13 8:03 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-kernel
>>> Sam Ravnborg <sam@ravnborg.org> 12.03.06 23:43:28 >>>
>On Thu, Mar 09, 2006 at 02:47:46PM +0100, Jan Beulich wrote:
>> Since .kconfig.d is used as a make dependency of include/linux/autoconf.h, it
>> should be written earlier than the header file, to avoid a subsequent rebuild
>> to consider the header outdated.
>
>Thanks Jan. I assume you saw this in reality?
Yes, I did.
>Applied.
Thanks, Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-13 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-09 13:47 [PATCH] fix time ordering of writes to .kconfig.d and include/linux/autoconf.h Jan Beulich
2006-03-12 22:43 ` Sam Ravnborg
2006-03-13 8:03 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome