From: Keith Owens <kaos@ocs.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>,
sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make gcc -align options .config-settable
Date: Fri, 08 Oct 2004 15:03:19 +1000 [thread overview]
Message-ID: <4439.1097211799@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Fri, 01 Oct 2004 15:17:51 MST." <20041001151751.3917d9d5.akpm@osdl.org>
On Fri, 1 Oct 2004 15:17:51 -0700,
Andrew Morton <akpm@osdl.org> wrote:
>Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> wrote:
>>
>> With all alignment options set to 1 (minimum alignment),
>> I've got 5% smaller vmlinux compared to one built with
>> default code alignment.
>>
>
>Sam, can you process this one?
>
>>
>>
>> +GCC_VERSION = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC))
>
>It bugs me that we're evaluating the same thing down in arch/i386/Makefile.
> Perhaps we should evaluate GCC_VERSION once only, as some top-level kbuild
>thing. So everyone can assume that it's present and correct?
Using '=' is wrong here, it will evaluate the complete expression every
time GCC_VERSION is tested. It should be ':='. The only time '='
should be used in a Makefile is when delayed evaluation is really
required, e.g. for strings that are the target of $(call).
next prev parent reply other threads:[~2004-10-08 5:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 19:26 Denis Vlasenko
2004-10-01 22:17 ` Andrew Morton
2004-10-04 22:04 ` Sam Ravnborg
2004-10-08 5:03 ` Keith Owens [this message]
2004-10-17 0:38 ` Sam Ravnborg
2004-10-04 18:38 ` Bill Davidsen
[not found] <2KBq9-2S1-15@gated-at.bofh.it>
2004-10-08 12:20 ` Andi Kleen
2004-10-08 17:10 ` Denis Vlasenko
2004-10-08 14:30 ` Grzegorz Kulewski
2004-10-08 20:42 ` Denis Vlasenko
2004-10-08 21:30 ` Grzegorz Kulewski
2004-10-08 15:42 ` Andi Kleen
2004-10-08 20:46 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4439.1097211799@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome