mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grzegorz Kulewski <kangur@polcom.net>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make gcc -align options .config-settable
Date: Fri, 8 Oct 2004 16:30:31 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.60.0410081618530.10253@alpha.polcom.net> (raw)
In-Reply-To: <200410081710.58766.vda@port.imtp.ilyichevsk.odessa.ua>

On Fri, 8 Oct 2004, Denis Vlasenko wrote:

> On Friday 08 October 2004 12:20, Andi Kleen wrote:
>> Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> writes:
>>> Resend.
>>>
>>> With all alignment options set to 1 (minimum alignment),
>>> I've got 5% smaller vmlinux compared to one built with
>>> default code alignment.
>>>
>>> Rediffed against 2.6.9-rc3.
>>> Please apply.
>>
>> I agree with the basic idea (the big alignments also always annoy
>> me when I look at disassembly), but I think your CONFIG options
>> are far too complicated. I don't think anybody will go as far as
>> to tune loops vs function calls.
>>
>> I would just do a single CONFIG_NO_ALIGNMENTS that sets everything to
>> 1, that should be enough.
>
> For me, yes, but there are people which are slightly less obsessed
> with code size than me.
>
> They might want to say "try to align to 16 bytes if
> it costs less than 5 bytes" etc.
>
> Also bencmarking people may do little research on real usefulness of
> various kinds of alignment.

I think that removing aligns completly will be very bad. I am Gentoo user 
and I set my user space CFLAGS for all system to -falign-loops 
-fno-align-<everything else>. I did not tested it in depth, but my simple 
tests show that unaligning loops is a very bad idea. Unaligning functions 
is safer since small and fast functions should be always inlined.


Thanks,

Grzegorz Kulewski


  reply	other threads:[~2004-10-08 14:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2KBq9-2S1-15@gated-at.bofh.it>
2004-10-08 12:20 ` Andi Kleen
2004-10-08 17:10   ` Denis Vlasenko
2004-10-08 14:30     ` Grzegorz Kulewski [this message]
2004-10-08 20:42       ` Denis Vlasenko
2004-10-08 21:30         ` Grzegorz Kulewski
2004-10-08 15:42     ` Andi Kleen
2004-10-08 20:46       ` Denis Vlasenko
2004-10-01 19:26 Denis Vlasenko
2004-10-01 22:17 ` Andrew Morton
2004-10-04 22:04   ` Sam Ravnborg
2004-10-08  5:03   ` Keith Owens
2004-10-17  0:38   ` Sam Ravnborg
2004-10-04 18:38 ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.60.0410081618530.10253@alpha.polcom.net \
    --to=kangur@polcom.net \
    --cc=ak@muc.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda@port.imtp.ilyichevsk.odessa.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®