From: Marek Vasut <marex@nabladev.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Pascal PAILLET-LME <p.paillet@st.com>,
Paul Cercueil <paul@crapouillou.net>,
kernel@dh-electronics.com
Subject: Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused
Date: Fri, 9 Jan 2026 16:39:38 +0100 [thread overview]
Message-ID: <444b4bc1-7724-4ea1-8e1e-8f5e7945eff2@nabladev.com> (raw)
In-Reply-To: <7ckcqck23wdwi2plotdl2rat4mb6ve4cl33jljkdro3h32h5pc@2k3fdxwa267p>
On 1/9/26 3:54 PM, Sean Nyekjaer wrote:
> On Fri, Jan 09, 2026 at 05:12:09AM +0100, Marek Vasut wrote:
>> Attempt to shut down again, in case the first attempt failed.
>> The STPMIC1 might get confused and the first regmap_update_bits()
>> returns with -ETIMEDOUT / -110 . If that or similar transient
>> failure occurs, try to shut down again. If the second attempt
>> fails, there is some bigger problem, report it to user.
>
> I don't think I have ever seen my devices fail to shutdown.
> Have you ever seen the second call fail?
I have sporadically seen the first call fail with timeout, not the
second one yet. If the second call fails, I think we have a real bad
hardware problem.
Maybe these issues are hidden on devices which use SCMI too, so they
never get properly fixed in the direct hardware access kernel drivers
anymore, sigh.
next prev parent reply other threads:[~2026-01-09 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 4:12 Marek Vasut
2026-01-09 14:54 ` Sean Nyekjaer
2026-01-09 15:39 ` Marek Vasut [this message]
2026-01-13 12:33 ` Lee Jones
2026-01-15 17:40 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444b4bc1-7724-4ea1-8e1e-8f5e7945eff2@nabladev.com \
--to=marex@nabladev.com \
--cc=kernel@dh-electronics.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.paillet@st.com \
--cc=paul@crapouillou.net \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®