From: Florian Fainelli <f.fainelli@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>, Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, charrer@alacritech.com, liodot@gmail.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver
Date: Tue, 15 Nov 2016 12:54:51 -0800 [thread overview]
Message-ID: <4450caf4-e1cf-5187-1337-c46b81b08708@gmail.com> (raw)
In-Reply-To: <69558f55-824a-7063-d9b3-ccc0a6113b87@gmx.de>
On 11/15/2016 12:46 PM, Lino Sanfilippo wrote:
>> Could this be pulled out into a standard PHY driver? All the SLIC
>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could
>> be a standard PHY hidden behind a single register.
>>
>> Andrew
>
> You are right, the driver should really use the defines in mii.h. I will fix this in
> a v2.
>
> Concerning the use of the PHY API: What would be the advantage of using it? Note that the
> phy is always internal and not interchangeable. Is not the interchangeability of PHYs
> the main reason for using this API?
Not reinventing the wheel primarily, while PHYLIB also solves the plug &
play aspect of external PHYs, it also solves the basic link management,
and consistent and reasonably well defined interface to user-space and
drivers (statistics reporting, link, auto-negotiation, EEE etc.).
--
Florian
next prev parent reply other threads:[~2016-11-15 20:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 4:47 Gigabit ethernet driver for Alacritechs SLIC devices Lino Sanfilippo
2016-11-13 4:47 ` [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver Lino Sanfilippo
2016-11-13 7:13 ` kbuild test robot
2016-11-13 8:38 ` kbuild test robot
2016-11-13 19:55 ` Andrew Lunn
2016-11-15 20:46 ` Lino Sanfilippo
2016-11-15 20:54 ` Florian Fainelli [this message]
2016-11-15 21:24 ` Lino Sanfilippo
2016-11-15 21:59 ` Andrew Lunn
2016-11-15 22:34 ` Lino Sanfilippo
2016-11-15 22:39 ` Florian Fainelli
2016-11-15 22:54 ` Lino Sanfilippo
2016-11-15 23:03 ` Andrew Lunn
2016-11-15 23:14 ` Lino Sanfilippo
2016-11-24 12:30 ` Aw: " Lino Sanfilippo
2016-11-13 4:47 ` [net-next 2/2] MAINTAINERS: add entry for slicoss " Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4450caf4-e1cf-5187-1337-c46b81b08708@gmail.com \
--to=f.fainelli@gmail.com \
--cc=LinoSanfilippo@gmx.de \
--cc=andrew@lunn.ch \
--cc=charrer@alacritech.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome