mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [[PATCH]] arm64: dts: qcom: hamoa: Enable cpufreq cooling devices
Date: Tue, 10 Feb 2026 10:13:44 +0530	[thread overview]
Message-ID: <4454b03d-9e1d-42a9-a8e6-177e3848a366@oss.qualcomm.com> (raw)
In-Reply-To: <iq2cirb4axawir4a7yjm5okf32ptzwdrvovji7tp2hdzmui7qg@pidosokrykgi>



On 2/3/2026 11:21 AM, Manivannan Sadhasivam wrote:
> On Wed, Jan 28, 2026 at 11:02:08AM +0530, Gaurav Kohli wrote:
>> Add cooling-cells property to the CPU nodes to support cpufreq
>> cooling devices.
>>
>> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
> 
> FYI: I submitted the similar version back in October:
> https://lore.kernel.org/linux-arm-msm/20251015065703.9422-1-mani@kernel.org/
> 

Hi Mani,

thanks for sharing this link. Could you please respin your patch. So 
that it can get merged? we need this cpufreq support enabled.

> - Mani
> 
>> ---
>>   arch/arm64/boot/dts/qcom/hamoa.dtsi | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
>> index db65c392e618..799e405a9f87 100644
>> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
>> @@ -75,6 +75,7 @@ cpu0: cpu@0 {
>>   			next-level-cache = <&l2_0>;
>>   			power-domains = <&cpu_pd0>, <&scmi_dvfs 0>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   
>>   			l2_0: l2-cache {
>>   				compatible = "cache";
>> @@ -91,6 +92,7 @@ cpu1: cpu@100 {
>>   			next-level-cache = <&l2_0>;
>>   			power-domains = <&cpu_pd1>, <&scmi_dvfs 0>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu2: cpu@200 {
>> @@ -101,6 +103,7 @@ cpu2: cpu@200 {
>>   			next-level-cache = <&l2_0>;
>>   			power-domains = <&cpu_pd2>, <&scmi_dvfs 0>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu3: cpu@300 {
>> @@ -111,6 +114,7 @@ cpu3: cpu@300 {
>>   			next-level-cache = <&l2_0>;
>>   			power-domains = <&cpu_pd3>, <&scmi_dvfs 0>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu4: cpu@10000 {
>> @@ -121,6 +125,7 @@ cpu4: cpu@10000 {
>>   			next-level-cache = <&l2_1>;
>>   			power-domains = <&cpu_pd4>, <&scmi_dvfs 1>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   
>>   			l2_1: l2-cache {
>>   				compatible = "cache";
>> @@ -137,6 +142,7 @@ cpu5: cpu@10100 {
>>   			next-level-cache = <&l2_1>;
>>   			power-domains = <&cpu_pd5>, <&scmi_dvfs 1>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu6: cpu@10200 {
>> @@ -147,6 +153,7 @@ cpu6: cpu@10200 {
>>   			next-level-cache = <&l2_1>;
>>   			power-domains = <&cpu_pd6>, <&scmi_dvfs 1>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu7: cpu@10300 {
>> @@ -157,6 +164,7 @@ cpu7: cpu@10300 {
>>   			next-level-cache = <&l2_1>;
>>   			power-domains = <&cpu_pd7>, <&scmi_dvfs 1>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu8: cpu@20000 {
>> @@ -167,6 +175,7 @@ cpu8: cpu@20000 {
>>   			next-level-cache = <&l2_2>;
>>   			power-domains = <&cpu_pd8>, <&scmi_dvfs 2>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   
>>   			l2_2: l2-cache {
>>   				compatible = "cache";
>> @@ -183,6 +192,7 @@ cpu9: cpu@20100 {
>>   			next-level-cache = <&l2_2>;
>>   			power-domains = <&cpu_pd9>, <&scmi_dvfs 2>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu10: cpu@20200 {
>> @@ -193,6 +203,7 @@ cpu10: cpu@20200 {
>>   			next-level-cache = <&l2_2>;
>>   			power-domains = <&cpu_pd10>, <&scmi_dvfs 2>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu11: cpu@20300 {
>> @@ -203,6 +214,7 @@ cpu11: cpu@20300 {
>>   			next-level-cache = <&l2_2>;
>>   			power-domains = <&cpu_pd11>, <&scmi_dvfs 2>;
>>   			power-domain-names = "psci", "perf";
>> +			#cooling-cells = <2>;
>>   		};
>>   
>>   		cpu-map {
>> -- 
>> 2.34.1
>>
> 


  reply	other threads:[~2026-02-10  4:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  5:32 Gaurav Kohli
2026-01-28  9:25 ` Konrad Dybcio
2026-02-03  5:51 ` Manivannan Sadhasivam
2026-02-10  4:43   ` Gaurav Kohli [this message]
2026-02-10  8:00     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4454b03d-9e1d-42a9-a8e6-177e3848a366@oss.qualcomm.com \
    --to=gaurav.kohli@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®