From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: ruanjinjie <ruanjinjie@huawei.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] block/swim3: add __init annotation to module init func
Date: Mon, 26 Sep 2022 19:37:53 +0200 [thread overview]
Message-ID: <4463371a-2b71-1153-7814-fdff59eb99cd@wanadoo.fr> (raw)
In-Reply-To: <20220926092241.1191846-1-ruanjinjie@huawei.com>
Le 26/09/2022 à 11:22, ruanjinjie a écrit :
> Add missing __init annotation to module init func.
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
> drivers/block/swim3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
> index da811a7da03f..1f65d506fbc9 100644
> --- a/drivers/block/swim3.c
> +++ b/drivers/block/swim3.c
> @@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver =
> };
>
>
> -int swim3_init(void)
> +int __init swim3_init(void)
> {
> macio_register_driver(&swim3_driver);
> return 0;
Hi,
unrelated, but should there be a swim3_exit() to call
macio_register_driver(), as already done in some other drivers using
these functions?
CJ
prev parent reply other threads:[~2022-09-26 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 9:22 ruanjinjie
2022-09-26 17:37 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4463371a-2b71-1153-7814-fdff59eb99cd@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®