* [PATCH -next] block/swim3: add __init annotation to module init func
@ 2022-09-26 9:22 ruanjinjie
2022-09-26 17:37 ` Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: ruanjinjie @ 2022-09-26 9:22 UTC (permalink / raw)
To: axboe, linux-block, linux-kernel; +Cc: ruanjinjie
Add missing __init annotation to module init func.
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
drivers/block/swim3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index da811a7da03f..1f65d506fbc9 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver =
};
-int swim3_init(void)
+int __init swim3_init(void)
{
macio_register_driver(&swim3_driver);
return 0;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] block/swim3: add __init annotation to module init func
2022-09-26 9:22 [PATCH -next] block/swim3: add __init annotation to module init func ruanjinjie
@ 2022-09-26 17:37 ` Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Christophe JAILLET @ 2022-09-26 17:37 UTC (permalink / raw)
To: ruanjinjie, axboe, linux-block, linux-kernel
Le 26/09/2022 à 11:22, ruanjinjie a écrit :
> Add missing __init annotation to module init func.
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
> drivers/block/swim3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
> index da811a7da03f..1f65d506fbc9 100644
> --- a/drivers/block/swim3.c
> +++ b/drivers/block/swim3.c
> @@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver =
> };
>
>
> -int swim3_init(void)
> +int __init swim3_init(void)
> {
> macio_register_driver(&swim3_driver);
> return 0;
Hi,
unrelated, but should there be a swim3_exit() to call
macio_register_driver(), as already done in some other drivers using
these functions?
CJ
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-26 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 9:22 [PATCH -next] block/swim3: add __init annotation to module init func ruanjinjie
2022-09-26 17:37 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®