mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Elaine Zhang <zhangqing@rock-chips.com>, heiko@sntech.de
Cc: mturquette@baylibre.com, sboyd@kernel.org,
	linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, xxx@rock-chips.com,
	xf@rock-chips.com, huangtao@rock-chips.com
Subject: Re: [PATCH v2 3/6] clk: rockchip: Export rockchip_register_softrst()
Date: Thu, 3 Sep 2020 18:02:36 +0800	[thread overview]
Message-ID: <44699e71-1b08-919f-ddf3-187aee67b8a0@rock-chips.com> (raw)
In-Reply-To: <20200903063147.10237-4-zhangqing@rock-chips.com>


On 2020/9/3 下午2:31, Elaine Zhang wrote:
> This is used by the Rockchip clk driver, export it to allow that
> driver to be compiled as a module..
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
>   drivers/clk/rockchip/softrst.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/rockchip/softrst.c b/drivers/clk/rockchip/softrst.c
> index 5f1ff5e47c4f..caba9055090b 100644
> --- a/drivers/clk/rockchip/softrst.c
> +++ b/drivers/clk/rockchip/softrst.c
> @@ -77,9 +77,9 @@ static const struct reset_control_ops rockchip_softrst_ops = {
>   	.deassert	= rockchip_softrst_deassert,
>   };
>   
> -void __init rockchip_register_softrst(struct device_node *np,
> -				      unsigned int num_regs,
> -				      void __iomem *base, u8 flags)
> +void rockchip_register_softrst(struct device_node *np,
> +			       unsigned int num_regs,
> +			       void __iomem *base, u8 flags)
>   {
>   	struct rockchip_softrst *softrst;
>   	int ret;
> @@ -107,3 +107,4 @@ void __init rockchip_register_softrst(struct device_node *np,
>   		kfree(softrst);
>   	}
>   };
> +EXPORT_SYMBOL(rockchip_register_softrst);

This looks good to me, so

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,

- Kever




  reply	other threads:[~2020-09-03 10:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  6:31 [PATCH v2 0/6] clk: rockchip: Support module build Elaine Zhang
2020-09-03  6:31 ` [PATCH v2 1/6] clk: rockchip: Use clk_hw_register_composite instead of clk_register_composite calls Elaine Zhang
2020-09-03 10:02   ` Kever Yang
2020-09-03 12:30   ` kernel test robot
2020-09-03  6:31 ` [PATCH v2 2/6] clk: rockchip: Export rockchip_clk_register_ddrclk() Elaine Zhang
2020-09-03 10:02   ` Kever Yang
2020-09-03  6:31 ` [PATCH v2 3/6] clk: rockchip: Export rockchip_register_softrst() Elaine Zhang
2020-09-03 10:02   ` Kever Yang [this message]
2020-09-03  6:31 ` [PATCH v2 4/6] clk: rockchip: Export some clock common APIs for module drivers Elaine Zhang
2020-09-03 10:02   ` Kever Yang
2020-09-03  6:32 ` [PATCH v2 5/6] clk: rockchip: fix the clk config to support module build Elaine Zhang
2020-09-03 10:03   ` Kever Yang
2020-09-03  6:32 ` [PATCH v2 6/6] clk: rockchip: rk3399: Support " Elaine Zhang
2020-09-03 10:03   ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44699e71-1b08-919f-ddf3-187aee67b8a0@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®