mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Paul Dickson <dickson@permanentmail.com>
Cc: Arjan van de Ven <arjan@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: Resume stops working between 2.6.16 and 2.6.17-rc1 on Dell Inspiron 6000
Date: Sun, 28 May 2006 17:49:35 -0400	[thread overview]
Message-ID: <447A1AEF.3040900@rtr.ca> (raw)
In-Reply-To: <20060528142951.2a7417cb.dickson@permanentmail.com>

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

We've just now put out a one-liner patch to libata that fixes
resume on my own Inspiron, and for other machines as well.

Does it fix the problem here too?  (copy of patch is attached)

[-- Attachment #2: 01_libata_resume.patch --]
[-- Type: text/x-patch, Size: 372 bytes --]

--- linux-2.6.17-rc5/drivers/scsi/libata-core.c
+++ linux/drivers/scsi/libata-core.c
@@ -4296,6 +4296,7 @@ static int ata_start_drive(struct ata_po
  */
 int ata_device_resume(struct ata_port *ap, struct ata_device *dev)
 {
 	if (ap->flags & ATA_FLAG_SUSPENDED) {
+		ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 200000);
 		ap->flags &= ~ATA_FLAG_SUSPENDED;
 		ata_set_mode(ap);

  reply	other threads:[~2006-05-28 21:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-28 21:02 Paul Dickson
2006-05-28 21:08 ` Bisects that are neither good nor bad Paul Dickson
2006-05-28 21:24   ` Rafael J. Wysocki
2006-05-28 21:34     ` Dave Jones
2006-05-29 11:37       ` Sanjoy Mahajan
2006-05-29 14:52         ` Dave Jones
2006-05-30 15:29           ` Pavel Machek
2006-06-03  8:58             ` Rafael J. Wysocki
2006-06-03  9:11             ` Russell King
2006-06-09  8:38               ` Pavel Machek
2006-06-09  8:42                 ` Russell King
2006-06-09  8:46                   ` fixing serial console over suspend [was Re: Bisects that are neither good nor bad] Pavel Machek
2006-06-09  8:51                     ` Russell King
2006-06-11 14:08                   ` Bisects that are neither good nor bad Russell King
2006-05-31  2:45           ` Paul Dickson
2006-05-28 22:02     ` Paul Dickson
2006-05-29  0:12       ` Paul Dickson
2006-05-28 21:11 ` Resume stops working between 2.6.16 and 2.6.17-rc1 on Dell Inspiron 6000 Arjan van de Ven
2006-05-28 21:29   ` Paul Dickson
2006-05-28 21:49     ` Mark Lord [this message]
2006-05-29  0:21       ` Paul Dickson
2006-05-29  0:40         ` Andrew Morton
2006-05-29  1:47           ` Paul Dickson
2006-05-29  3:02         ` Mark Lord
2006-05-29 15:12           ` Pavel Machek
2006-05-31  2:38             ` Paul Dickson
2006-05-29  3:03         ` Mark Lord
     [not found] <6hAGq-6t8-1@gated-at.bofh.it>
     [not found] ` <6hAQd-6ET-27@gated-at.bofh.it>
     [not found]   ` <6hB9t-735-3@gated-at.bofh.it>
     [not found]     ` <6hBsR-7sn-21@gated-at.bofh.it>
     [not found]       ` <6hDO1-2D9-3@gated-at.bofh.it>
     [not found]         ` <6hDXI-2Om-15@gated-at.bofh.it>
     [not found]           ` <6hF3n-4kh-1@gated-at.bofh.it>
2006-05-29  2:55             ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447A1AEF.3040900@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=arjan@infradead.org \
    --cc=dickson@permanentmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome