[PATCH] pinctrl: pinctrl-zynq: Add warning for not to use 'io-standard'

[PATCH] pinctrl: pinctrl-zynq: Add warning for not to use 'io-standard'

[Sai Krishna Potthuri]

This patch add warning message saying 'io-standard' property is deprecated
and instead use 'power-source' property for configuring power supplies.
This gives an indication for Zynq pinctrl users to migrate to use
'power-source' property.

Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
---
 drivers/pinctrl/pinctrl-zynq.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
index a96af8a..5b269b6 100644
--- a/drivers/pinctrl/pinctrl-zynq.c
+++ b/drivers/pinctrl/pinctrl-zynq.c
@@ -1028,6 +1028,8 @@ static int zynq_pinconf_cfg_get(struct pinctrl_dev *pctldev,
 		break;
 	}
 	case PIN_CONFIG_IOSTANDARD:
+		dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source");
+		fallthrough;
 	case PIN_CONFIG_POWER_SOURCE:
 		arg = zynq_pinconf_iostd_get(reg);
 		break;
@@ -1079,6 +1081,8 @@ static int zynq_pinconf_cfg_set(struct pinctrl_dev *pctldev,
 
 			break;
 		case PIN_CONFIG_IOSTANDARD:
+			dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source");
+			fallthrough;
 		case PIN_CONFIG_POWER_SOURCE:
 			if (arg <= zynq_iostd_min || arg >= zynq_iostd_max) {
 				dev_warn(pctldev->dev,
-- 
2.1.1

Re: [PATCH] pinctrl: pinctrl-zynq: Add warning for not to use 'io-standard'

[Michal Simek]

On 8/18/21 7:53 AM, Sai Krishna Potthuri wrote:
> This patch add warning message saying 'io-standard' property is deprecated
> and instead use 'power-source' property for configuring power supplies.
> This gives an indication for Zynq pinctrl users to migrate to use
> 'power-source' property.
> 
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
> ---
>  drivers/pinctrl/pinctrl-zynq.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index a96af8a..5b269b6 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -1028,6 +1028,8 @@ static int zynq_pinconf_cfg_get(struct pinctrl_dev *pctldev,
>  		break;
>  	}
>  	case PIN_CONFIG_IOSTANDARD:
> +		dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source");
> +		fallthrough;
>  	case PIN_CONFIG_POWER_SOURCE:
>  		arg = zynq_pinconf_iostd_get(reg);
>  		break;
> @@ -1079,6 +1081,8 @@ static int zynq_pinconf_cfg_set(struct pinctrl_dev *pctldev,
>  
>  			break;
>  		case PIN_CONFIG_IOSTANDARD:
> +			dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source");
> +			fallthrough;
>  		case PIN_CONFIG_POWER_SOURCE:
>  			if (arg <= zynq_iostd_min || arg >= zynq_iostd_max) {
>  				dev_warn(pctldev->dev,
> 


Acked-by: Michal Simek <michal.simek@xilinx.com>

Linus: would be good to know how long we should keep the support for
this deprecated dt property.

Thanks,
Michal

Re: [PATCH] pinctrl: pinctrl-zynq: Add warning for not to use 'io-standard'

[Linus Walleij]

On Wed, Aug 18, 2021 at 8:00 AM Michal Simek <michal.simek@xilinx.com> wrote:

> Linus: would be good to know how long we should keep the support for
> this deprecated dt property.

We use the "noone hears the tree fall in an empty forest"-metric.
If no user suffers, we can drop it. Determining that requires some
kind of reasoning about when that happens, and then the maintainer
of the driver decides.

Yours,
Linus Walleij