mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Maxime Ripard <maxime@cerno.tech>,
	mturquette@baylibre.com, Stephen Boyd <sboyd@kernel.org>
Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-sunxi@googlegroups.com, Andre Heider <a.heider@gmail.com>
Subject: Re: [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check
Date: Thu, 11 Feb 2021 06:39:43 +0100	[thread overview]
Message-ID: <44806885.xO3ZHcXyXd@jernej-laptop> (raw)
In-Reply-To: <161301048085.1254594.6786751472945742937@swboyd.mtv.corp.google.com>

Dne četrtek, 11. februar 2021 ob 03:28:00 CET je Stephen Boyd napisal(a):
> Quoting Maxime Ripard (2021-02-10 02:29:04)
> 
> > Hi Mike, Stephen,
> > 
> > On Tue, Feb 09, 2021 at 06:58:56PM +0100, Jernej Skrabec wrote:
> > > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current
> > > one. Fix that.
> > > 
> > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when
> > > allowed") Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > > Tested-by: Andre Heider <a.heider@gmail.com>
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > 
> > This is a last minute fix for us, can you merge it into clk-fixes
> > directly?
> > 
> > Acked-by: Maxime Ripard <mripard@kernel.org>
> 
> It's also fixing a problem that's been around since v5.0. Is something
> broken that needs fixing this late? The motivation could be added to the
> commit text because right now it looks like a typo fix spotted visually.

Yes, it's needed. Without this patch, 4k@60 doesn't work and probably some 
other resolutions too. That's why it's send with other display related fixes. 
This is part of solution for longstanding display issues.

Best regards,
Jernej




  reply	other threads:[~2021-02-11  5:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 17:58 [PATCH v3 0/5] sunxi: fix H6 HDMI related issues Jernej Skrabec
2021-02-09 17:58 ` [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check Jernej Skrabec
2021-02-10 10:29   ` Maxime Ripard
2021-02-11  2:28     ` Stephen Boyd
2021-02-11  5:39       ` Jernej Škrabec [this message]
2021-02-12  3:06   ` Stephen Boyd
2021-02-09 17:58 ` [PATCH v3 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel Jernej Skrabec
2021-02-09 17:58 ` [PATCH v3 3/5] drm/sun4i: dw-hdmi: always set clock rate Jernej Skrabec
2021-02-09 17:58 ` [PATCH v3 4/5] drm/sun4i: Fix H6 HDMI PHY configuration Jernej Skrabec
2021-02-09 17:59 ` [PATCH v3 5/5] drm/sun4i: dw-hdmi: Fix max. frequency for H6 Jernej Skrabec
2021-02-10 10:29 ` [PATCH v3 0/5] sunxi: fix H6 HDMI related issues Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44806885.xO3ZHcXyXd@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=a.heider@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime@cerno.tech \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®