mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Christoph Hellwig <hch@infradead.org>,
	"Serge E. Hallyn" <serue@us.ibm.com>
Cc: weihs@ict.tuwien.ac.at, linux1394-devel@lists.sourceforge.net,
	bcollins@debian.org, "Eric W. Biederman" <ebiederm@xmission.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kthread conversion: convert ieee1394 from kernel_thread
Date: Sat, 10 Jun 2006 17:11:42 +0200	[thread overview]
Message-ID: <448AE12E.5060002@s5r6.in-berlin.de> (raw)
In-Reply-To: <20060610144205.GA13850@infradead.org>

Christoph Hellwig wrote:
> On Sat, Jun 10, 2006 at 09:31:00AM -0500, Serge E. Hallyn wrote:
> 
>>Convert ieee1394 from using deprecated kernel_thread to
>>kthread api.
>>
>>Compiles fine, but unfortunately I am unable to test.
> 
> 
> This patch does various things wrong or at least suboptimal.  See
> '[PATCH] ieee1394_core: switch to kthread API' sent to the ieee1394-devel
> list on the 14th of April for a patch the gets the formalisms right,
> although I wasn't able to test it either.

The patch Christoph is referring to, together with a small fix by Andrew 
Morton, is in -mm and is IMO ready to go into Linux 2.6.18. However this 
patch converts only the khpsbpkt (packet/ transactions handler), not the 
knodemgrd (bus management and protocol driver dispatcher).

Serge, could you reduce your patch to the nodemgr part and resubmit? A 
diff against current -mm would be most welcome. If you develop on top of 
Linus' tree, you could get current 1394 subsystem code which is almost 
identical to latest -mm here:
http://me.in-berlin.de/~s5r6/linux1394/updates/

Thanks,
-- 
Stefan Richter
-=====-=-==- -==- -=-=-
http://arcgraph.de/sr/

  reply	other threads:[~2006-06-10 15:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-10 14:31 Serge E. Hallyn
2006-06-10 14:42 ` Christoph Hellwig
2006-06-10 15:11   ` Stefan Richter [this message]
2006-06-10 15:42     ` Christoph Hellwig
2006-06-10 16:34       ` Ben Collins
2006-06-10 16:38         ` Christoph Hellwig
2006-06-10 18:08           ` Ben Collins
2006-06-10 18:37             ` Christoph Hellwig
2006-06-17 18:44               ` Stefan Richter
2006-06-18 10:29                 ` Stefan Richter
2006-06-18 16:57                 ` [PATCH 2.6.17-rc6-mm2 0/6] ieee1394: nodemgr: misc API conversions Stefan Richter
2006-06-18 16:57                   ` [PATCH 2.6.17-rc6-mm2 1/6] ieee1394: nodemgr: remove unnecessary includes Stefan Richter
2006-06-18 16:59                     ` [PATCH 2.6.17-rc6-mm2 2/6] ieee1394: do not spawn a kernel_thread for user-initiated bus rescan Stefan Richter
2006-06-18 17:00                       ` [PATCH 2.6.17-rc6-mm2 3/6] ieee1394: make module parameter ignore_drivers writable Stefan Richter
2006-06-18 17:02                         ` [PATCH 2.6.17-rc6-mm2 4/6] ieee1394: nodemgr: switch to kthread API Stefan Richter
2006-06-18 17:03                           ` [PATCH 2.6.17-rc6-mm2 5/6] ieee1394: nodemgr: replace reset semaphore Stefan Richter
2006-06-18 17:05                             ` [PATCH 2.6.17-rc6-mm2 6/6] ieee1394: convert nodemgr_serialize semaphore to mutex Stefan Richter
2006-06-10 18:12           ` [PATCH] kthread conversion: convert ieee1394 from kernel_thread Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448AE12E.5060002@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=bcollins@debian.org \
    --cc=ebiederm@xmission.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=serue@us.ibm.com \
    --cc=weihs@ict.tuwien.ac.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®