* [PATCH] [MMC] Another stray 'io' reference
@ 2006-08-06 23:40 Pierre Ossman
2006-08-06 23:41 ` Pierre Ossman
2006-08-07 13:48 ` Russell King
0 siblings, 2 replies; 3+ messages in thread
From: Pierre Ossman @ 2006-08-06 23:40 UTC (permalink / raw)
To: rmk+lkml; +Cc: Pierre Ossman, linux-kernel
Another misuse of the global 'io' variable instead of the local 'base'.
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
---
drivers/mmc/wbsd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/wbsd.c b/drivers/mmc/wbsd.c
index ce86887..c351c6d 100644
--- a/drivers/mmc/wbsd.c
+++ b/drivers/mmc/wbsd.c
@@ -1773,7 +1773,7 @@ static int __devinit wbsd_init(struct de
/*
* Request resources.
*/
- ret = wbsd_request_resources(host, io, irq, dma);
+ ret = wbsd_request_resources(host, base, irq, dma);
if (ret) {
wbsd_release_resources(host);
wbsd_free_mmc(dev);
@@ -1861,6 +1861,7 @@ static void __devexit wbsd_shutdown(stru
static int __devinit wbsd_probe(struct platform_device *dev)
{
+ /* Use the module parameters for resources */
return wbsd_init(&dev->dev, io, irq, dma, 0);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [MMC] Another stray 'io' reference
2006-08-06 23:40 [PATCH] [MMC] Another stray 'io' reference Pierre Ossman
@ 2006-08-06 23:41 ` Pierre Ossman
2006-08-07 13:48 ` Russell King
1 sibling, 0 replies; 3+ messages in thread
From: Pierre Ossman @ 2006-08-06 23:41 UTC (permalink / raw)
To: linux-kernel
Pierre Ossman wrote:
> Another misuse of the global 'io' variable instead of the local 'base'.
>
> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
> ---
>
This should be it. I did a search for 'io' in the entire driver and
found no other incorrect uses.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [MMC] Another stray 'io' reference
2006-08-06 23:40 [PATCH] [MMC] Another stray 'io' reference Pierre Ossman
2006-08-06 23:41 ` Pierre Ossman
@ 2006-08-07 13:48 ` Russell King
1 sibling, 0 replies; 3+ messages in thread
From: Russell King @ 2006-08-07 13:48 UTC (permalink / raw)
To: Pierre Ossman; +Cc: Pierre Ossman, linux-kernel
On Mon, Aug 07, 2006 at 01:40:04AM +0200, Pierre Ossman wrote:
> Another misuse of the global 'io' variable instead of the local 'base'.
Applied, thanks.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-07 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-06 23:40 [PATCH] [MMC] Another stray 'io' reference Pierre Ossman
2006-08-06 23:41 ` Pierre Ossman
2006-08-07 13:48 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome