mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@muc.de>, "Andrew Morton" <akpm@osdl.org>
Cc: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>,
	<torvalds@osdl.org>, <davej@redhat.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: 2.6.18-rc3-g3b445eea BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug()
Date: Mon, 07 Aug 2006 09:18:22 +0100	[thread overview]
Message-ID: <44D7136E.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20060807012638.GA42404@muc.de>

>> It's a false-positive in this case - the backtrace was complete.  It would
>> be good if we could make the did-we-get-stuck detector a bit smarter.  Even
>> special-casing "sysenter_past_esp" would stop a lot of this..
>
>Actually it's not completely false in this case -- it should
>have reached user mode and stopped there, but for some reason
>I didn't and already stopped still in the kernel.
>
>Most likely the CFI annotation for that sysenter path is not complete.

Correct, the return point of sysexit (SYSENTER_RETURN) is still in kernel space,
but its annotations are invisible to the unwinder. We should make the VDSO be
treated as user-mode code despite living above PAGE_OFFSET.

>It's on my todo list to investigate but I still hope Jan does it first ;-)

I'll try to, once I've got through moving the Xen code from 2.6.16 to 2.6.18-rc3

Jan

  reply	other threads:[~2006-08-07  8:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-04 19:04 Michal Piotrowski
2006-08-04 19:24 ` Linus Torvalds
2006-08-04 22:24   ` Dave Jones
2006-08-05  0:31     ` Dave Jones
2006-08-05  2:10       ` Dave Jones
2006-08-05  2:23         ` Dave Jones
2006-08-05  2:49           ` Dave Jones
2006-08-05  6:47             ` Dave Jones
2006-08-05  7:46               ` Andrew Morton
2006-08-05 19:47                 ` Dave Jones
2006-08-05 20:02                   ` Andrew Morton
2006-08-06  1:12                 ` Andrew Morton
2006-08-05 10:54               ` Michal Piotrowski
2006-08-05 11:11                 ` Michal Piotrowski
2006-08-05 11:26                   ` Michal Piotrowski
2006-08-05 18:47                     ` Dave Jones
2006-08-05 21:15                       ` Michal Piotrowski
2006-08-06 16:59               ` Michal Piotrowski
2006-08-06 18:05                 ` Dave Jones
2006-08-06 19:32                 ` Andrew Morton
2006-08-07  1:26                   ` Andi Kleen
2006-08-07  8:18                     ` Jan Beulich [this message]
2006-08-15 12:23                     ` Jan Beulich
2006-08-05 22:14 art
2006-08-06  1:23 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44D7136E.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome