From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Maxim Levitsky <maximlevitsky@gmail.com>,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 9/9] memstick: Delete an unnecessary check in msb_update_block()
Date: Sat, 7 Jan 2017 21:04:54 +0100 [thread overview]
Message-ID: <44ade3ec-9c63-d08b-4544-b0a48ac13594@users.sourceforge.net> (raw)
In-Reply-To: <64dfa775-4e4a-bdb0-7b55-41f43ccdf11a@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 7 Jan 2017 20:21:02 +0100
Further exception handling will only be performed after an error code
was set. Thus remove a redundant check for a local variable at the end.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/memstick/core/ms_block.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
index 861f6a76136d..013f317d566b 100644
--- a/drivers/memstick/core/ms_block.c
+++ b/drivers/memstick/core/ms_block.c
@@ -1154,10 +1154,8 @@ static int msb_update_block(struct msb_data *msb, u16 lba,
return 0;
}
out:
- if (error) {
- pr_err("block update error after %d tries, switching to r/o mode", try);
- msb->read_only = true;
- }
+ pr_err("block update error after %d tries, switching to r/o mode", try);
+ msb->read_only = true;
return error;
}
--
2.11.0
prev parent reply other threads:[~2017-01-07 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 19:50 [PATCH 0/9] memstick: Fine-tuning for some function implementations SF Markus Elfring
2017-01-07 19:53 ` [PATCH 1/9] memstick: Split a condition check in msb_ftl_initialize() SF Markus Elfring
2017-01-07 19:54 ` [PATCH 2/9] memstick: Use kmalloc_array() " SF Markus Elfring
2017-01-07 19:55 ` [PATCH 3/9] memstick: Delete unwanted spaces behind three function parameters SF Markus Elfring
2017-01-07 19:56 ` [PATCH 4/9] memstick: Improve two size determinations in msb_resume() SF Markus Elfring
2017-01-07 19:57 ` [PATCH 5/9] memstick: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-01-07 19:58 ` [PATCH 6/9] memstick: Improve a size determination in msb_probe() SF Markus Elfring
2017-01-07 19:59 ` [PATCH 7/9] memstick: Improve another size determination in msb_read_boot_blocks() Markus Elfring
2017-01-07 20:01 ` SF Markus Elfring
2017-01-07 20:03 ` [PATCH 8/9] memstick: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-01-07 20:04 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ade3ec-9c63-d08b-4544-b0a48ac13594@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome