From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org,
Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 7/9] memstick: Improve another size determination in msb_read_boot_blocks()
Date: Sat, 7 Jan 2017 21:01:38 +0100 [thread overview]
Message-ID: <67fecf0a-9e26-c150-d123-ee5cf33c0397@users.sourceforge.net> (raw)
In-Reply-To: <64dfa775-4e4a-bdb0-7b55-41f43ccdf11a@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 7 Jan 2017 20:00:16 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/memstick/core/ms_block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
index a30c0ae95ae5..98ab5764050b 100644
--- a/drivers/memstick/core/ms_block.c
+++ b/drivers/memstick/core/ms_block.c
@@ -1202,7 +1202,7 @@ static int msb_read_boot_blocks(struct msb_data *msb)
dbg_verbose("Start of a scan for the boot blocks");
if (!msb->boot_page) {
- page = kmalloc(sizeof(struct ms_boot_page)*2, GFP_KERNEL);
+ page = kmalloc(sizeof(*page) * 2, GFP_KERNEL);
if (!page)
return -ENOMEM;
--
2.11.0
next prev parent reply other threads:[~2017-01-07 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 19:50 [PATCH 0/9] memstick: Fine-tuning for some function implementations SF Markus Elfring
2017-01-07 19:53 ` [PATCH 1/9] memstick: Split a condition check in msb_ftl_initialize() SF Markus Elfring
2017-01-07 19:54 ` [PATCH 2/9] memstick: Use kmalloc_array() " SF Markus Elfring
2017-01-07 19:55 ` [PATCH 3/9] memstick: Delete unwanted spaces behind three function parameters SF Markus Elfring
2017-01-07 19:56 ` [PATCH 4/9] memstick: Improve two size determinations in msb_resume() SF Markus Elfring
2017-01-07 19:57 ` [PATCH 5/9] memstick: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-01-07 19:58 ` [PATCH 6/9] memstick: Improve a size determination in msb_probe() SF Markus Elfring
2017-01-07 19:59 ` [PATCH 7/9] memstick: Improve another size determination in msb_read_boot_blocks() Markus Elfring
2017-01-07 20:01 ` SF Markus Elfring [this message]
2017-01-07 20:03 ` [PATCH 8/9] memstick: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-01-07 20:04 ` [PATCH 9/9] memstick: Delete an unnecessary check in msb_update_block() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fecf0a-9e26-c150-d123-ee5cf33c0397@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome