[PATCH v2] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[PATCH v2] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Ernest Van Hoecke]

From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

qcom,calibration-variant is the generic Qualcomm Wi-Fi DT property for
selecting board-specific calibration data when the device identity alone
is ambiguous.

Commit 06cca100ad08 ("wifi: ath12k: support calibration-variant from
device tree") implemented support for this property in the ath12k
driver.

WCN7850 can be used in systems where the PCI device ID and machine
compatible are identical across product variants, or across regions with
different regulations. For regulatory changes, the hardware description
does not change, but the vendor-provided calibration data can differ. In
that case neither the PCI identity nor the machine compatible can
identify the required data, so DT needs an explicit calibration variant.

The ath10k, ath11k and ath12k WSI bindings already allow this generic
property for the same class of board-data selection. Allow it for
WCN7850 PCIe devices as well.

Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
---
Changes in v2:
- Rebased
- Updated commit message
- Link to v1: https://lore.kernel.org/r/20260701-ath12k-calibration-variant-v1-1-d3eddaabf026@toradex.com
---
 Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
index dc68dd59988f..cf3e1fd99c12 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
@@ -54,6 +54,12 @@ properties:
   vddpcie1p8-supply:
     description: VDD_PCIE_1P8 supply regulator handle
 
+  qcom,calibration-variant:
+    $ref: /schemas/types.yaml#/definitions/string
+    description:
+      String to uniquely identify variant of the calibration data for designs
+      with colliding bus and device ids
+
 required:
   - compatible
   - reg

---
base-commit: 1d8e73163ef933624341075f576e2f36ef9133f7
change-id: 20260701-ath12k-calibration-variant-b7850f7ffd7c

Best regards,
-- 
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

Re: [PATCH v2] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Ernest Van Hoecke]

On Mon, Sep 07, 2026 at 04:17:20PM +0200, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> qcom,calibration-variant is the generic Qualcomm Wi-Fi DT property for
> selecting board-specific calibration data when the device identity alone
> is ambiguous.
> 
> Commit 06cca100ad08 ("wifi: ath12k: support calibration-variant from
> device tree") implemented support for this property in the ath12k
> driver.
> 
> WCN7850 can be used in systems where the PCI device ID and machine
> compatible are identical across product variants, or across regions with
> different regulations. For regulatory changes, the hardware description
> does not change, but the vendor-provided calibration data can differ. In
> that case neither the PCI identity nor the machine compatible can
> identify the required data, so DT needs an explicit calibration variant.
> 
> The ath10k, ath11k and ath12k WSI bindings already allow this generic
> property for the same class of board-data selection. Allow it for
> WCN7850 PCIe devices as well.
> 
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> ---
> Changes in v2:
> - Rebased
> - Updated commit message
> - Link to v1: https://lore.kernel.org/r/20260701-ath12k-calibration-variant-v1-1-d3eddaabf026@toradex.com
> ---
>  Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> index dc68dd59988f..cf3e1fd99c12 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> @@ -54,6 +54,12 @@ properties:
>    vddpcie1p8-supply:
>      description: VDD_PCIE_1P8 supply regulator handle
>  
> +  qcom,calibration-variant:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      String to uniquely identify variant of the calibration data for designs
> +      with colliding bus and device ids
> +
>  required:
>    - compatible
>    - reg
> 
> ---
> base-commit: 1d8e73163ef933624341075f576e2f36ef9133f7
> change-id: 20260701-ath12k-calibration-variant-b7850f7ffd7c
> 
> Best regards,
> -- 
> Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 

Hi,

Just a friendly ping on this since this since 06cca100ad08 ("wifi:
ath12k: support calibration-variant from device tree") has been in the
tree for a while now.

Kind regards,
Ernest

Re: [PATCH v2] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Rob Herring (Arm)]

On Mon, 07 Sep 2026 16:17:20 +0200, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> qcom,calibration-variant is the generic Qualcomm Wi-Fi DT property for
> selecting board-specific calibration data when the device identity alone
> is ambiguous.
> 
> Commit 06cca100ad08 ("wifi: ath12k: support calibration-variant from
> device tree") implemented support for this property in the ath12k
> driver.
> 
> WCN7850 can be used in systems where the PCI device ID and machine
> compatible are identical across product variants, or across regions with
> different regulations. For regulatory changes, the hardware description
> does not change, but the vendor-provided calibration data can differ. In
> that case neither the PCI identity nor the machine compatible can
> identify the required data, so DT needs an explicit calibration variant.
> 
> The ath10k, ath11k and ath12k WSI bindings already allow this generic
> property for the same class of board-data selection. Allow it for
> WCN7850 PCIe devices as well.
> 
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> ---
> Changes in v2:
> - Rebased
> - Updated commit message
> - Link to v1: https://lore.kernel.org/r/20260701-ath12k-calibration-variant-v1-1-d3eddaabf026@toradex.com
> ---
>  Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Sorry, not sure why this wasn't showing up for me. You may want to 
resend it in case it is not in wireless queue.

Rob

Re: [PATCH v2] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Jeff Johnson]

On 10/30/2026 7:53 AM, Rob Herring (Arm) wrote:
> 
> On Mon, 07 Sep 2026 16:17:20 +0200, Ernest Van Hoecke wrote:
>> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>>
>> qcom,calibration-variant is the generic Qualcomm Wi-Fi DT property for
>> selecting board-specific calibration data when the device identity alone
>> is ambiguous.
>>
>> Commit 06cca100ad08 ("wifi: ath12k: support calibration-variant from
>> device tree") implemented support for this property in the ath12k
>> driver.
>>
>> WCN7850 can be used in systems where the PCI device ID and machine
>> compatible are identical across product variants, or across regions with
>> different regulations. For regulatory changes, the hardware description
>> does not change, but the vendor-provided calibration data can differ. In
>> that case neither the PCI identity nor the machine compatible can
>> identify the required data, so DT needs an explicit calibration variant.
>>
>> The ath10k, ath11k and ath12k WSI bindings already allow this generic
>> property for the same class of board-data selection. Allow it for
>> WCN7850 PCIe devices as well.
>>
>> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>> ---
>> Changes in v2:
>> - Rebased
>> - Updated commit message
>> - Link to v1: https://lore.kernel.org/r/20260701-ath12k-calibration-variant-v1-1-d3eddaabf026@toradex.com
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> 
> Sorry, not sure why this wasn't showing up for me. You may want to 
> resend it in case it is not in wireless queue.
> 
> Rob

It's in my queue, will pick it up now.

/jeff

Re: [PATCH v2] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Jeff Johnson]

On Mon, 07 Sep 2026 16:17:20 +0200, Ernest Van Hoecke wrote:
> qcom,calibration-variant is the generic Qualcomm Wi-Fi DT property for
> selecting board-specific calibration data when the device identity alone
> is ambiguous.
> 
> Commit 06cca100ad08 ("wifi: ath12k: support calibration-variant from
> device tree") implemented support for this property in the ath12k
> driver.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850
      commit: 75bc725cd92b2b4dfa76850ce5983aacb52d894c

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>