From: Guenter Roeck <linux@roeck-us.net>
To: vjardin@free.fr, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Charles Hsu <ythsu0511@gmail.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646
Date: Wed, 29 Jul 2026 21:10:52 -0700 [thread overview]
Message-ID: <44db442e-95c8-47f0-92b6-81279710ff33@roeck-us.net> (raw)
In-Reply-To: <20260729-mpq8646_v0-v6-2-98848151cdb4@free.fr>
On 7/29/26 14:51, Vincent Jardin via B4 Relay wrote:
> From: Vincent Jardin <vjardin@free.fr>
>
> The MPS MPQ8646 PMBus step-down converter uses the same
> mps,vout-fb-divider-ratio-permille property with the same constraints
> (maximum 2047, default 706) as the mps,mpq8785, so add its compatible
> to the existing schema.
>
The driver is a separate driver, making this a bit unusual.
I'll leave it up to the devicetree maintainers to decide if
this should be a new bindings file or not.
Guenter
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
> Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> index 90970a0433e9..d7a32fb3b7af 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> @@ -18,6 +18,7 @@ properties:
> - mps,mpm3695
> - mps,mpm3695-25
> - mps,mpm82504
> + - mps,mpq8646
> - mps,mpq8785
>
> reg:
> @@ -52,7 +53,9 @@ allOf:
> - if:
> properties:
> compatible:
> - const: mps,mpq8785
> + enum:
> + - mps,mpq8646
> + - mps,mpq8785
> then:
> properties:
> mps,vout-fb-divider-ratio-permille:
>
next prev parent reply other threads:[~2026-07-30 4:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 21:51 [PATCH v6 0/4] hwmon: pmbus: add MPS MPQ8646 support Vincent Jardin via B4 Relay
2026-07-29 21:51 ` [PATCH v6 1/4] hwmon: (pmbus/core) export pmbus_check_and_notify_faults() Vincent Jardin via B4 Relay
2026-07-29 21:51 ` [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646 Vincent Jardin via B4 Relay
2026-07-30 4:10 ` Guenter Roeck [this message]
2026-07-30 6:55 ` Vincent Jardin
2026-07-30 16:07 ` Guenter Roeck
2026-07-29 21:51 ` [PATCH v6 3/4] hwmon: pmbus: add MPQ8646 driver Vincent Jardin via B4 Relay
2026-07-29 21:51 ` [PATCH v6 4/4] hwmon: pmbus: mpq8646: gate the writes Vincent Jardin via B4 Relay
2026-07-30 4:26 ` Guenter Roeck
2026-07-30 5:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44db442e-95c8-47f0-92b6-81279710ff33@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Markus.Elfring@web.de \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vjardin@free.fr \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®