From: Guenter Roeck <linux@roeck-us.net>
To: Vincent Jardin <vjardin@free.fr>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Charles Hsu <ythsu0511@gmail.com>,
Markus Elfring <Markus.Elfring@web.de>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646
Date: Thu, 30 Jul 2026 09:07:17 -0700 [thread overview]
Message-ID: <de535ebe-bc46-4a1e-82e0-f347ef3f16a8@roeck-us.net> (raw)
In-Reply-To: <amr1ar1eLeZ69oGY@L30177.local>
On 7/29/26 23:55, Vincent Jardin wrote:
> Hi Guenter,
>
> Le 29/07/26 21:10, Guenter Roeck a écrit :
>> On 7/29/26 14:51, Vincent Jardin via B4 Relay wrote:
>>> From: Vincent Jardin <vjardin@free.fr>
>>>
>>> The MPS MPQ8646 PMBus step-down converter uses the same
>>> mps,vout-fb-divider-ratio-permille property with the same constraints
>>> (maximum 2047, default 706) as the mps,mpq8785, so add its compatible
>>> to the existing schema.
>>>
>>
>> The driver is a separate driver, making this a bit unusual.
>> I'll leave it up to the devicetree maintainers to decide if
>> this should be a new bindings file or not.
>
> Because of Krzysztof's review of v5: he asked exactly for it
> since mps,mpq8785.yaml already carries the same property, the same
> constraints and the same defaults:
>
> see https://lore.kernel.org/all/20260727-sceptical-finicky-waxbill-d7ecbf@quoll/
> "...Everything is the same as mps,mpq8785.yam, so why it cannot be added
> there? Just grow the list of if:then: to cover your specific
> constraints."
>
> v5 had it as a separate mps,mpq8646.yaml file. I'll follow whatever
> the DT maintainers prefer, but so should we consider that it complies
> with Krzysztof's argument ?
>
Yes, and I guess that answers my question.
I'd like to see that documented somewhere for future reference, but either
I don't find it or the documentation is vague.
Again, the question is: if bindings for two devices use the same properties,
but the chips are different enough to warrant separate drivers, should the
bindings be combined into a single bindings file or should the bindings files
be separate ?
As an interesting twist, the actual binding (mps,vout-fb-divider-ratio-permille)
really applies to many PMBus chips, specifically those supporting the
PMBUS_VOUT_SCALE_LOOP command.
Thanks,
Guenter
next prev parent reply other threads:[~2026-07-30 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 21:51 [PATCH v6 0/4] hwmon: pmbus: add MPS MPQ8646 support Vincent Jardin via B4 Relay
2026-07-29 21:51 ` [PATCH v6 1/4] hwmon: (pmbus/core) export pmbus_check_and_notify_faults() Vincent Jardin via B4 Relay
2026-07-29 21:51 ` [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646 Vincent Jardin via B4 Relay
2026-07-30 4:10 ` Guenter Roeck
2026-07-30 6:55 ` Vincent Jardin
2026-07-30 16:07 ` Guenter Roeck [this message]
2026-07-29 21:51 ` [PATCH v6 3/4] hwmon: pmbus: add MPQ8646 driver Vincent Jardin via B4 Relay
2026-07-29 21:51 ` [PATCH v6 4/4] hwmon: pmbus: mpq8646: gate the writes Vincent Jardin via B4 Relay
2026-07-30 4:26 ` Guenter Roeck
2026-07-30 5:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de535ebe-bc46-4a1e-82e0-f347ef3f16a8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Markus.Elfring@web.de \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vjardin@free.fr \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®