From: Baochen Qiang <quic_bqiang@quicinc.com>
To: Johan Hovold <johan+linaro@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>
Cc: Miaoqing Pan <quic_miaoqing@quicinc.com>,
Remi Pommarel <repk@triplefau.lt>,
<linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] wifi: ath12k: use plain access for descriptor length
Date: Wed, 25 Jun 2025 09:53:49 +0800 [thread overview]
Message-ID: <4503f964-f2e1-42ff-a263-613f340f9a7c@quicinc.com> (raw)
In-Reply-To: <20250617084402.14475-3-johan+linaro@kernel.org>
On 6/17/2025 4:44 PM, Johan Hovold wrote:
> The read memory barrier added by commit 6b67d2cf14ea ("wifi: ath12k: fix
> ring-buffer corruption") is enough to guarantee ordering also for plain
> descriptor accesses if the length helper is ever inlined so drop the
> unnecessary READ_ONCE().
>
> Tested-on: WCN7850 hw2.0 WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/net/wireless/ath/ath12k/hal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/hal.c b/drivers/net/wireless/ath/ath12k/hal.c
> index f8bd3837b9dc..726969cfcaec 100644
> --- a/drivers/net/wireless/ath/ath12k/hal.c
> +++ b/drivers/net/wireless/ath/ath12k/hal.c
> @@ -1950,7 +1950,7 @@ u32 ath12k_hal_ce_dst_status_get_length(struct hal_ce_srng_dst_status_desc *desc
> {
> u32 len;
>
> - len = le32_get_bits(READ_ONCE(desc->flags), HAL_CE_DST_STATUS_DESC_FLAGS_LEN);
> + len = le32_get_bits(desc->flags, HAL_CE_DST_STATUS_DESC_FLAGS_LEN);
> desc->flags &= ~cpu_to_le32(HAL_CE_DST_STATUS_DESC_FLAGS_LEN);
>
> return len;
Reviewed-by: Baochen Qiang <quic_bqiang@quicinc.com>
next prev parent reply other threads:[~2025-06-25 1:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 8:43 [PATCH v3 0/4] wifi: ath12k: fix dest ring-buffer corruption Johan Hovold
2025-06-17 8:43 ` [PATCH v3 1/4] " Johan Hovold
2025-06-25 1:53 ` Baochen Qiang
2025-06-17 8:44 ` [PATCH v3 2/4] wifi: ath12k: use plain access for descriptor length Johan Hovold
2025-06-25 1:53 ` Baochen Qiang [this message]
2025-06-17 8:44 ` [PATCH v3 3/4] wifi: ath12k: fix source ring-buffer corruption Johan Hovold
2025-06-25 1:54 ` Baochen Qiang
2025-06-17 8:44 ` [PATCH v3 4/4] wifi: ath12k: fix dest ring-buffer corruption when ring is full Johan Hovold
2025-06-25 1:54 ` Baochen Qiang
2025-06-26 23:15 ` [PATCH v3 0/4] wifi: ath12k: fix dest ring-buffer corruption Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4503f964-f2e1-42ff-a263-613f340f9a7c@quicinc.com \
--to=quic_bqiang@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_miaoqing@quicinc.com \
--cc=repk@triplefau.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®