* [PATCH] MODSIGN: Fix a compilation warning in extract-cert
@ 2015-09-08 13:41 David Howells
2015-09-08 14:03 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2015-09-08 13:41 UTC (permalink / raw)
To: jmorris; +Cc: linux-security-module, keyrings, linux-kernel, jim.epost
Fix the following warning when compiling extract-cert:
scripts/extract-cert.c: In function ‘write_cert’:
scripts/extract-cert.c:89:2: warning: format not a string literal and no format arguments [-Wformat-security]
ERR(!i2d_X509_bio(wb, x509), cert_dst);
^
whereby the ERR() macro is taking cert_dst as the format string. "%s"
should be used as the format string as the path could contain special
characters.
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by : David Woodhouse <david.woodhouse@intel.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/extract-cert.c b/scripts/extract-cert.c
index fd0db015c65c..10d23ca9f617 100644
--- a/scripts/extract-cert.c
+++ b/scripts/extract-cert.c
@@ -86,7 +86,7 @@ static void write_cert(X509 *x509)
ERR(!wb, "%s", cert_dst);
}
X509_NAME_oneline(X509_get_subject_name(x509), buf, sizeof(buf));
- ERR(!i2d_X509_bio(wb, x509), cert_dst);
+ ERR(!i2d_X509_bio(wb, x509), "%s", cert_dst);
if (kbuild_verbose)
fprintf(stderr, "Extracted cert: %s\n", buf);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MODSIGN: Fix a compilation warning in extract-cert
2015-09-08 13:41 [PATCH] MODSIGN: Fix a compilation warning in extract-cert David Howells
@ 2015-09-08 14:03 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2015-09-08 14:03 UTC (permalink / raw)
To: jmorris
Cc: dhowells, linux-security-module, keyrings, linux-kernel, jim.epost
This patch is aimed at security/next.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-08 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-08 13:41 [PATCH] MODSIGN: Fix a compilation warning in extract-cert David Howells
2015-09-08 14:03 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®