From: Daniel Tang <dt.tangr@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
"fabian@ritter-vogt.de Vogt" <fabian@ritter-vogt.de>,
Lionel Debroux <lionel_debroux@yahoo.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHv3 1/6] arm: Initial TI-Nspire support
Date: Sun, 12 May 2013 19:22:45 +1000 [thread overview]
Message-ID: <453A23B8-7FE0-42D6-BBEC-B6CC3604EE01@gmail.com> (raw)
In-Reply-To: <20130512090610.GF18614@n2100.arm.linux.org.uk>
On 12/05/2013, at 7:06 PM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Sun, May 12, 2013 at 02:22:56PM +1000, Daniel Tang wrote:
>>
>> + .bpp = 8,
>> + .grayscale = 1
>> +};
>
> Still no capabilities in the above - how does the CLCD controller know
> which of BGR or RGB output and which format these panels support?
>
> Each entry needs a .caps = CLCD_CAP_xxx | CLCD_CAP_xxx listing the
> formats supported there.
>
> Unless panels and the board have a .caps entry, the caps system won't
> be used.
Fair enough.
>
>> +static struct clcd_board nspire_clcd_data = {
>> + .name = "LCD",
>> + .caps = CLCD_CAP_ALL,
>
> Your board has logic to support the RGB444/BGR444 mode? If not, setting
> CLCD_CAP_ALL is incorrect.
I believe the grayscale panel supports the xGx444 modes - unsure about the colour one. Since I'm using the same struct clcd_board for both panels, I thought I'd just set caps to work with both to simplify.
Should I set board caps to panel caps on setup?
Cheers,
next prev parent reply other threads:[~2013-05-12 9:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 4:22 [RFC PATCHv3 0/6] " Daniel Tang
2013-05-12 4:22 ` [RFC PATCHv3 1/6] " Daniel Tang
2013-05-12 9:06 ` Russell King - ARM Linux
2013-05-12 9:22 ` Daniel Tang [this message]
2013-05-12 4:22 ` [RFC PATCHv3 2/6] arm: Add device trees for TI-Nspire Daniel Tang
2013-05-15 14:10 ` Arnd Bergmann
2013-05-12 4:22 ` [RFC PATCHv3 3/6] clk: Add TI-Nspire clock drivers Daniel Tang
2013-05-15 14:07 ` Arnd Bergmann
2013-05-16 8:31 ` Daniel Tang
2013-05-16 12:17 ` Arnd Bergmann
2013-05-19 11:09 ` Daniel Tang
2013-05-19 19:48 ` Arnd Bergmann
2013-05-20 11:19 ` Daniel Tang
2013-05-20 12:26 ` Arnd Bergmann
2013-05-12 4:22 ` [RFC PATCHv3 4/6] clocksource: Add TI-Nspire timer drivers Daniel Tang
2013-05-14 8:03 ` Linus Walleij
2013-05-14 11:51 ` Daniel Tang
2013-05-17 13:17 ` Linus Walleij
2013-05-18 6:40 ` Daniel Tang
2013-05-20 12:49 ` Linus Walleij
2013-05-12 4:23 ` [RFC PATCHv3 5/6] input: Add TI-Nspire keypad driver Daniel Tang
2013-05-12 4:23 ` [RFC PATCHv3 6/6] irqchip: Add TI-Nspire irqchip Daniel Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453A23B8-7FE0-42D6-BBEC-B6CC3604EE01@gmail.com \
--to=dt.tangr@gmail.com \
--cc=arnd@arndb.de \
--cc=fabian@ritter-vogt.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lionel_debroux@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®