From: Daniel Tang <dt.tangr@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
Linus Walleij <linus.walleij@linaro.org>,
"fabian@ritter-vogt.de Vogt" <fabian@ritter-vogt.de>,
Lionel Debroux <lionel_debroux@yahoo.fr>,
linux-kernel@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [RFC PATCHv3 3/6] clk: Add TI-Nspire clock drivers
Date: Sun, 19 May 2013 21:09:17 +1000 [thread overview]
Message-ID: <F8915E01-0FCA-4C9F-8440-63B5A73B349B@gmail.com> (raw)
In-Reply-To: <201305161417.28133.arnd@arndb.de>
On 16/05/2013, at 10:17 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 16 May 2013, Daniel Tang wrote:
>>
>> On 16/05/2013, at 12:07 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>>> You are missing a binding in Documentation/devicetree, same as for some of
>>> the other drivers in this series.
>>
>> Should we be adding a vendor prefix to it too? If so, we're not sure whether
>> to use "ti," or not since this isn't an official port by TI.
>
> The binding describes the hardware, it should not matter who does the port.
> However, any part of the tree that is not actually from TI should have a
> vendor prefix indicating who made that part. IIRC, the SoC used in there
> is from TI, so you should use something else for the on-soc components.
>
If the vendors for the on-SOC components are unknown, should we just leave the compatible strings as is (i.e. "nspire-XXX")?
>>> It seems strange to assign the clk_name variable to node->name
>>> first and then overriding it with the clock-output-names property.
>>> Is that intentional? If so, please explain it in a comment.
>>>
>>
>> I copied that bit of boilerplate from drivers/clk/clk-fixed-rate.c but
>> I'm guessing it's to use the node name as the clock name unless there
>> is a property called "clock-output-names"
>
> Ah, I see. It seems you forgot to add the clock maintainer to Cc in the
> mail. Mike is the one who will have to take you patch anyway, so I assume
> he will comment on this if you did it wrong.
>
> Arnd
next prev parent reply other threads:[~2013-05-19 11:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 4:22 [RFC PATCHv3 0/6] arm: Initial TI-Nspire support Daniel Tang
2013-05-12 4:22 ` [RFC PATCHv3 1/6] " Daniel Tang
2013-05-12 9:06 ` Russell King - ARM Linux
2013-05-12 9:22 ` Daniel Tang
2013-05-12 4:22 ` [RFC PATCHv3 2/6] arm: Add device trees for TI-Nspire Daniel Tang
2013-05-15 14:10 ` Arnd Bergmann
2013-05-12 4:22 ` [RFC PATCHv3 3/6] clk: Add TI-Nspire clock drivers Daniel Tang
2013-05-15 14:07 ` Arnd Bergmann
2013-05-16 8:31 ` Daniel Tang
2013-05-16 12:17 ` Arnd Bergmann
2013-05-19 11:09 ` Daniel Tang [this message]
2013-05-19 19:48 ` Arnd Bergmann
2013-05-20 11:19 ` Daniel Tang
2013-05-20 12:26 ` Arnd Bergmann
2013-05-12 4:22 ` [RFC PATCHv3 4/6] clocksource: Add TI-Nspire timer drivers Daniel Tang
2013-05-14 8:03 ` Linus Walleij
2013-05-14 11:51 ` Daniel Tang
2013-05-17 13:17 ` Linus Walleij
2013-05-18 6:40 ` Daniel Tang
2013-05-20 12:49 ` Linus Walleij
2013-05-12 4:23 ` [RFC PATCHv3 5/6] input: Add TI-Nspire keypad driver Daniel Tang
2013-05-12 4:23 ` [RFC PATCHv3 6/6] irqchip: Add TI-Nspire irqchip Daniel Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F8915E01-0FCA-4C9F-8440-63B5A73B349B@gmail.com \
--to=dt.tangr@gmail.com \
--cc=arnd@arndb.de \
--cc=fabian@ritter-vogt.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lionel_debroux@yahoo.fr \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®