mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Robin Murphy <robin.murphy@arm.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"will@kernel.org" <will@kernel.org>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	Linuxarm <linuxarm@huawei.com>,
	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	"chenxiang (M)" <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options
Date: Mon, 14 Jun 2021 15:19:57 +0100	[thread overview]
Message-ID: <453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com> (raw)
In-Reply-To: <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com>

On 14/06/2021 15:11, Robin Murphy wrote:
> On 2021-06-14 08:53, John Garry wrote:
>> On 12/06/2021 03:22, Lu Baolu wrote:
>>> On 2021/6/11 20:20, John Garry wrote:
>>>> @@ -453,8 +452,7 @@ static int __init intel_iommu_setup(char *str)
>>>>                pr_warn("intel_iommu=forcedac deprecated; use
>>>> iommu.forcedac instead\n");
>>>>                iommu_dma_forcedac = true;
>>>>            } else if (!strncmp(str, "strict", 6)) {
>>>> -            pr_info("Disable batched IOTLB flush\n");
>>>> -            intel_iommu_strict = 1;
>>>> +            iommu_set_dma_strict(true);
>>> I would like to deprecate this command line and ask users to use
>>> iommu.strict instead.
>> ok, but then I should probably make the AMD driver also officially
>> support this.
> Oops, I should have documented that "iommu.strict" already applies to
> x86 as well. The interaction with the driver-specific parameters is a
> bit weird and unintuitive, but it was done knowingly. Let me quickly
> spin a kernel-parameters.txt fix for that...

So I already had a pending patch here for the same to be included in 
this series:
https://github.com/hisilicon/kernel-dev/commit/2375a2d888d78de9eb7d91d6f2c5891395300a96

If you want to do it, then ok. I might have to reorder the series though...

Thanks,
John



  reply	other threads:[~2021-06-14 14:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 12:20 [PATCH v12 0/5] Enhance " John Garry
2021-06-11 12:20 ` [PATCH v12 1/5] iommu: Print strict or lazy mode at init time John Garry
2021-06-14 15:54   ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 2/5] iommu: Enhance IOMMU default DMA mode build options John Garry
2021-06-12  1:21   ` Lu Baolu
2021-06-14  8:11     ` John Garry
2021-06-12  2:12   ` Lu Baolu
2021-06-14 16:03   ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 3/5] iommu/vt-d: Add support for " John Garry
2021-06-12  2:14   ` Lu Baolu
2021-06-14  8:03     ` John Garry
2021-06-15  7:26       ` Lu Baolu
2021-06-15  8:25         ` Robin Murphy
2021-06-16  8:42           ` Lu Baolu
2021-06-12  2:22   ` Lu Baolu
2021-06-14  7:53     ` John Garry
2021-06-14 14:11       ` Robin Murphy
2021-06-14 14:19         ` John Garry [this message]
2021-06-14 15:05           ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 4/5] iommu/amd: " John Garry
2021-06-11 12:20 ` [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict() John Garry
2021-06-12  2:23   ` Lu Baolu
2021-06-14  7:46     ` John Garry
2021-06-14 16:25   ` Robin Murphy
2021-06-14 17:03     ` John Garry
2021-06-14 17:19       ` Robin Murphy
2021-06-14 17:24         ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com \
    --to=john.garry@huawei.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=robin.murphy@arm.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®