mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: Ensure proper suspend/resume ordering
Date: Thu, 17 Sep 2015 02:07:48 +0200	[thread overview]
Message-ID: <4548634.pC6GYZYGWm@vostro.rjw.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1509161523230.1993-100000@iolanthe.rowland.org>

On Wednesday, September 16, 2015 03:27:55 PM Alan Stern wrote:
> On Wed, 16 Sep 2015, Grygorii Strashko wrote:
> 
> > I think, It should prohibited to probe devices during suspend/hibernation.
> > And solution introduced in this patch might help to fix it -
> > in general, we could do :
> > - add sync point on suspend enter: wait_for_device_probe() and
> > - prohibit probing: move all devices which will request probing into
> > deferred_probe list
> > - one suspend exit: allow probing and do driver_deferred_probe_trigger
> 
> That could work; it's a good idea.
> 
> > I'd like to mention here that this patch will work only
> > if dmp_list will be filled according device creation order ("parent<-child" dependencies)
> > *AND* according device's probing order ("supplier<-consumer").
> > So, if there is the case when Parent device can be probed AFTER its children
> > - it will not work, because "parent<-child" dependencies will not be tracked
> > any more :( Sry, I could not even imagine that such crazy case exist :'(
> 
> If we avoid moving devices to the end of the dpm_list when they already 
> have children, then we should be okay, right?
> 
> > Are there any other subsystems with the same behavior like PCI?
> 
> I don't know.
> 
> > If not - probably, it could be fixed in PCI subsystem using device_pm_move_after() or 
> > device_move() in PCIe ports probe.
> > if yes - ... maybe we can scan/re-check and reorder dpm_list on suspend enter and
> > restore ("parent<-child" dependencies).
> 
> > Truth is that smth. need to be done 100%. Personally, I was hit by this issue also,
> >  and it cost me 3 hours of debugging and I came up with the same patch as
> > Bill Huang, then spent some time trying to understand what is wrong with PCI
> > - finally, I've just changed the order of my devices in DT :)
> > 
> > Also, I think, it will be good to have this patch in -next to collect more feedbacks.
> 
> I like the idea of forcing all probes during a sleep transition to be 
> deferred.  We could carry them out just before unfreezing the user 
> threads.  That combined with the change mentioned above ought to be 
> worth testing.

Agreed.

Thanks,
Rafael


  reply	other threads:[~2015-09-16 23:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 10:19 Thierry Reding
2015-09-10 10:58 ` Grygorii Strashko
2015-09-10 22:08 ` Rafael J. Wysocki
2015-09-11 12:03   ` Thierry Reding
2015-09-11 19:01     ` Alan Stern
2015-09-11 22:28       ` Rafael J. Wysocki
2015-09-12 17:40         ` Alan Stern
2015-09-15  0:40           ` Rafael J. Wysocki
2015-09-15 14:23             ` Alan Stern
2015-09-16  1:04               ` Rafael J. Wysocki
2015-09-16 13:39         ` Grygorii Strashko
2015-09-16 19:27           ` Alan Stern
2015-09-17  0:07             ` Rafael J. Wysocki [this message]
2015-09-17 15:48               ` Grygorii Strashko
2015-09-17 23:59                 ` Rafael J. Wysocki
2015-09-18  0:03                   ` Rafael J. Wysocki
2015-10-01 18:14                   ` Grygorii Strashko
2015-09-15 16:10       ` Thierry Reding
2015-09-15 19:18         ` Alan Stern
2015-09-16  1:28           ` Rafael J. Wysocki
2015-09-16 13:38             ` Grygorii Strashko
2015-09-16 16:58               ` Alan Stern
2015-09-16 17:08             ` Alan Stern
2015-09-16 13:16           ` Thierry Reding
2015-09-16 19:22             ` Alan Stern
2015-09-17  0:27               ` Rafael J. Wysocki
2015-09-17  2:04                 ` Rafael J. Wysocki
2015-09-17 17:02                   ` Alan Stern
2015-09-17 18:43                     ` Rafael J. Wysocki
2015-09-17 21:06                       ` Alan Stern
2015-09-18  0:13                         ` Rafael J. Wysocki
2015-09-18 15:55                       ` Thierry Reding
2015-09-18 23:07                         ` Rafael J. Wysocki
2015-09-21  8:51                           ` Thierry Reding
2015-09-21 14:34                             ` Alan Stern
2015-09-22  0:26                               ` Rafael J. Wysocki
2015-09-22  1:22                                 ` Alan Stern
2015-09-22  0:39                             ` Rafael J. Wysocki
2015-09-17  5:40                 ` Tomeu Vizoso
2015-09-17 18:15                   ` Rafael J. Wysocki
2015-09-17 19:21                     ` Alan Stern
2015-09-11 22:38     ` Rafael J. Wysocki
2015-09-15 15:53       ` Thierry Reding
2015-09-16  1:18         ` Rafael J. Wysocki
2015-09-16 13:38           ` Grygorii Strashko
2015-09-17  0:55             ` Rafael J. Wysocki
2015-09-11 14:05   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4548634.pC6GYZYGWm@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®