mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Yu Liao <liaoyu15@huawei.com>, shuah@kernel.org
Cc: xiexiuqi@huawei.com, Jason@zx2c4.com,
	christophe.leroy@csgroup.eu, broonie@kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests: vDSO: Explicitly include sched.h
Date: Tue, 8 Oct 2024 15:50:33 -0600	[thread overview]
Message-ID: <4564d4e0-6384-4b84-a330-fdd6a026c9d6@linuxfoundation.org> (raw)
In-Reply-To: <20241008023332.19902-1-liaoyu15@huawei.com>

On 10/7/24 20:33, Yu Liao wrote:
> The previous commit introduced the use of CLONE_NEWTIME without including
> <sched.h> which contains its definition.
> 
> Add an explicit include of <sched.h> to ensure that CLONE_NEWTIME
> is correctly defined before it is used.
> 
> Fixes: 2aec90036dcd ("selftests: vDSO: ensure vgetrandom works in a time namespace")
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
> Changes in v2:
> - Include <sched.h> instead of <linux/sched.h>
> 
> v1: https://lore.kernel.org/all/20240919111841.20226-1-liaoyu15@huawei.com/
> 
>   tools/testing/selftests/vDSO/vdso_test_getrandom.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index 72a1d9b43a84..ddf37e3ab18b 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -11,6 +11,7 @@
>   #include <string.h>
>   #include <time.h>
>   #include <unistd.h>
> +#include <sched.h>
>   #include <signal.h>
>   #include <sys/auxv.h>
>   #include <sys/mman.h>

Thank you. Applied to linux-kselftest fixes for next rc.

thanks,
-- Shuah

      reply	other threads:[~2024-10-08 21:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  2:33 Yu Liao
2024-10-08 21:50 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4564d4e0-6384-4b84-a330-fdd6a026c9d6@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=Jason@zx2c4.com \
    --cc=broonie@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=liaoyu15@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®