* [PATCH v2] selftests: vDSO: Explicitly include sched.h
@ 2024-10-08 2:33 Yu Liao
2024-10-08 21:50 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Yu Liao @ 2024-10-08 2:33 UTC (permalink / raw)
To: shuah
Cc: liaoyu15, xiexiuqi, Jason, christophe.leroy, broonie,
linux-kselftest, linux-kernel
The previous commit introduced the use of CLONE_NEWTIME without including
<sched.h> which contains its definition.
Add an explicit include of <sched.h> to ensure that CLONE_NEWTIME
is correctly defined before it is used.
Fixes: 2aec90036dcd ("selftests: vDSO: ensure vgetrandom works in a time namespace")
Signed-off-by: Yu Liao <liaoyu15@huawei.com>
---
Changes in v2:
- Include <sched.h> instead of <linux/sched.h>
v1: https://lore.kernel.org/all/20240919111841.20226-1-liaoyu15@huawei.com/
tools/testing/selftests/vDSO/vdso_test_getrandom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
index 72a1d9b43a84..ddf37e3ab18b 100644
--- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
+++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
@@ -11,6 +11,7 @@
#include <string.h>
#include <time.h>
#include <unistd.h>
+#include <sched.h>
#include <signal.h>
#include <sys/auxv.h>
#include <sys/mman.h>
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] selftests: vDSO: Explicitly include sched.h
2024-10-08 2:33 [PATCH v2] selftests: vDSO: Explicitly include sched.h Yu Liao
@ 2024-10-08 21:50 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-10-08 21:50 UTC (permalink / raw)
To: Yu Liao, shuah
Cc: xiexiuqi, Jason, christophe.leroy, broonie, linux-kselftest,
linux-kernel, Shuah Khan
On 10/7/24 20:33, Yu Liao wrote:
> The previous commit introduced the use of CLONE_NEWTIME without including
> <sched.h> which contains its definition.
>
> Add an explicit include of <sched.h> to ensure that CLONE_NEWTIME
> is correctly defined before it is used.
>
> Fixes: 2aec90036dcd ("selftests: vDSO: ensure vgetrandom works in a time namespace")
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
> Changes in v2:
> - Include <sched.h> instead of <linux/sched.h>
>
> v1: https://lore.kernel.org/all/20240919111841.20226-1-liaoyu15@huawei.com/
>
> tools/testing/selftests/vDSO/vdso_test_getrandom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index 72a1d9b43a84..ddf37e3ab18b 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <time.h>
> #include <unistd.h>
> +#include <sched.h>
> #include <signal.h>
> #include <sys/auxv.h>
> #include <sys/mman.h>
Thank you. Applied to linux-kselftest fixes for next rc.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-08 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-08 2:33 [PATCH v2] selftests: vDSO: Explicitly include sched.h Yu Liao
2024-10-08 21:50 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®