From: "Huang, Kai" <kai.huang@intel.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>
Cc: "mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"Gao, Chao" <chao.gao@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"Lindgren, Tony" <tony.lindgren@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>
Subject: Re: [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>
Date: Wed, 2 Apr 2025 22:00:15 +0000 [thread overview]
Message-ID: <45674f2bb8c7bb09f0f3a29d7c4fb9bdc14b22d7.camel@intel.com> (raw)
In-Reply-To: <112c4cdb-4757-4625-ad18-9402340cd47e@linux.intel.com>
> >
> > > +via the same buffer. The 'ret' field represents the return value.
> > >
> > return value of the GetQuote TDVMCALL?
> Yes, thereturn code of the GetQuote TDVMCALL.
> >
> > > The userspace
> > > +should update the return value before resuming the vCPU according to TDX GHCI
> > > +spec.
> > >
> > I don't quite follow. Why userspace should "update" the return value?
> Because only userspace knows whether the request has been queued successfully.
>
> According to GHCI, TDG.VP.VMCALL<GetQuote> API allows one TD to issue multiple
> requests. This is implementation specific as to how many concurrent requests
> are allowed. The TD should be able to handle TDG.VP.VMCALL_RETRY if it chooses
> to issue multiple requests simultaneously.
> So the userspace may set the return code as TDG.VP.VMCALL_RETRY.
OK. How about just say:
The 'ret' field represents the return value of the GetQuote request. KVM only
bridges the request to userspace VMM after sanity checks, and the userspace VMM
is responsible for setting up the return value since only userspace knows
whether the request has been queued successfully or not.
next prev parent reply other threads:[~2025-04-02 22:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 0:15 [PATCH 0/2] TDX attestation support Binbin Wu
2025-04-02 0:15 ` [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote> Binbin Wu
2025-04-02 0:53 ` Huang, Kai
2025-04-02 8:58 ` Huang, Kai
2025-04-02 12:53 ` Binbin Wu
2025-04-02 13:16 ` Binbin Wu
2025-04-02 22:05 ` Huang, Kai
2025-04-02 22:00 ` Huang, Kai [this message]
2025-04-08 2:35 ` Binbin Wu
2025-04-09 13:49 ` Sean Christopherson
2025-04-10 0:06 ` Binbin Wu
2025-04-10 0:15 ` Huang, Kai
2025-04-02 22:19 ` Huang, Kai
2025-04-07 1:00 ` Binbin Wu
2025-04-15 1:49 ` Xiaoyao Li
2025-04-15 1:51 ` Edgecombe, Rick P
2025-04-15 1:55 ` Binbin Wu
2025-04-02 0:15 ` [PATCH 2/2] KVM: TDX: Handle TDG.VP.VMCALL<SetupEventNotifyInterrupt> Binbin Wu
2025-04-02 0:20 ` [PATCH 0/2] TDX attestation support Edgecombe, Rick P
2025-04-11 1:42 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45674f2bb8c7bb09f0f3a29d7c4fb9bdc14b22d7.camel@intel.com \
--to=kai.huang@intel.com \
--cc=adrian.hunter@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.ylinen@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@intel.com \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®