mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
	"mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
	"Huang, Kai" <kai.huang@intel.com>,
	"Li, Xiaoyao" <xiaoyao.li@intel.com>,
	"Lindgren, Tony" <tony.lindgren@intel.com>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>
Subject: Re: [PATCH 0/2] TDX attestation support
Date: Wed, 2 Apr 2025 00:20:08 +0000	[thread overview]
Message-ID: <b5bb71fdb3f9b4a1b08a169b2d6c9c70210c6d02.camel@intel.com> (raw)
In-Reply-To: <20250402001557.173586-1-binbin.wu@linux.intel.com>

On Wed, 2025-04-02 at 08:15 +0800, Binbin Wu wrote:
> Opens
> =====
> Linux TDX guests don't use SetupEventNotifyInterrupt for TD attestation
> currently. If no other TDX guests use it, the support for
> SetupEventNotifyInterrupt could be dropped. But it would require an opt-in
> if the support is added later.

I think we shouldn't be afraid of opt-ins. We will need one sooner or later.
Better to not add the second exit with no users.

> 
> In this patch series, KVM does sanity checks for the TDVMCALLs so that
> different userspace VMMs can save the code for sanity checks. But it could
> be dropped if it's preferred to keep KVM code simpler and let the userspace
> VMMs take the responsibility.

I say we push it to userspace to keep KVM as small as possible.

  parent reply	other threads:[~2025-04-02  0:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02  0:15 Binbin Wu
2025-04-02  0:15 ` [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote> Binbin Wu
2025-04-02  0:53   ` Huang, Kai
2025-04-02  8:58     ` Huang, Kai
2025-04-02 12:53     ` Binbin Wu
2025-04-02 13:16       ` Binbin Wu
2025-04-02 22:05         ` Huang, Kai
2025-04-02 22:00       ` Huang, Kai
2025-04-08  2:35         ` Binbin Wu
2025-04-09 13:49       ` Sean Christopherson
2025-04-10  0:06         ` Binbin Wu
2025-04-10  0:15         ` Huang, Kai
2025-04-02 22:19   ` Huang, Kai
2025-04-07  1:00     ` Binbin Wu
2025-04-15  1:49   ` Xiaoyao Li
2025-04-15  1:51     ` Edgecombe, Rick P
2025-04-15  1:55       ` Binbin Wu
2025-04-02  0:15 ` [PATCH 2/2] KVM: TDX: Handle TDG.VP.VMCALL<SetupEventNotifyInterrupt> Binbin Wu
2025-04-02  0:20 ` Edgecombe, Rick P [this message]
2025-04-11  1:42   ` [PATCH 0/2] TDX attestation support Binbin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5bb71fdb3f9b4a1b08a169b2d6c9c70210c6d02.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=chao.gao@intel.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikko.ylinen@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=seanjc@google.com \
    --cc=tony.lindgren@intel.com \
    --cc=xiaoyao.li@intel.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®