From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
Sagi Grimberg <sagi@grimberg.me>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH v1 2/2] nvme-fcloop: queue work items correctly
Date: Thu, 15 Jun 2023 12:06:27 +0200 [thread overview]
Message-ID: <457be842-a975-9ab5-8aca-02141e99b6a0@suse.de> (raw)
In-Reply-To: <20230615094356.14878-3-dwagner@suse.de>
On 6/15/23 11:43, Daniel Wagner wrote:
> The arguments passed to list_add_tail are reversed. The new element is
> first argument and the queue/list is the second one.
>
> Fixes: 38803fcffb5b ("nvme-fcloop: fix deallocation of working context")
> Fixes: 437c0b824dbd ("nvme-fcloop: add target to host LS request support")
>
> Cc: James Smart <jsmart2021@gmail.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/target/fcloop.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
next prev parent reply other threads:[~2023-06-15 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 9:43 [PATCH v1 0/2] nvme-fc: Fix blktests hangers Daniel Wagner
2023-06-15 9:43 ` [PATCH v1 1/2] nvme-fc: Do not wait in vain when unloading module Daniel Wagner
2023-06-15 10:06 ` Hannes Reinecke
2023-06-15 9:43 ` [PATCH v1 2/2] nvme-fcloop: queue work items correctly Daniel Wagner
2023-06-15 10:06 ` Hannes Reinecke [this message]
2023-06-19 7:55 ` [PATCH v1 0/2] nvme-fc: Fix blktests hangers Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457be842-a975-9ab5-8aca-02141e99b6a0@suse.de \
--to=hare@suse.de \
--cc=dwagner@suse.de \
--cc=jsmart2021@gmail.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®