* [PATCH v2] dt-bindings: axis-fifo: Added missing binding
@ 2026-09-17 11:48 Daniel Matyas
2026-09-17 11:58 ` Greg Kroah-Hartman
2026-09-17 18:24 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Matyas @ 2026-09-17 11:48 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Daniel Matyas
Cc: linux-staging, Daniel Matyas, devicetree, linux-kernel
From: Daniel Matyas <matyasdaniel005@gmail.com>
drivers/staging/axis-fifo/axis-fifo.txt file described how the
devicetree of the driver should look like. Convert it to .yaml file.
Issue found by checkpatch.
Signed-off-by: Daniel Matyas <matyasdaniel005@gmail.com>
Signed-off-by: Daniel Matyas <matyasdaniel006@gmail.com>
---
Sorry for adding another email. I got locked out of the first one for 30
days...
v2: Corrected syntax errors in compatible:
xlnx,axis-fifo-mm-s-4.1 -> xlnx,axi-fifo-mm-s-4.1
xlnx,axis-fifo-mm-s-4.2 -> xlnx,axi-fifo-mm-s-4.2
xlnx,axis-fifo-mm-s-4.3 -> xlnx,axi-fifo-mm-s-4.3
.../axis-fifo/xlnx,axi-fifo-mm-s.yaml | 257 ++++++++++++++++++
1 file changed, 257 insertions(+)
create mode 100644 Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
diff --git a/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
new file mode 100644
index 000000000000..e1b46a2a4b4b
--- /dev/null
+++ b/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
@@ -0,0 +1,257 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/axis-fifo/xlnx,axi-fifo-mm-s.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xilinx AXI-Stream FIFO v4.1 IP core
+
+maintainers:
+ - Daniel Matyas <matyasdaniel005@gmail.com>
+
+description: |
+ This IP core has read and write AXI-Stream FIFOs, the contents of which can
+ be accessed from the AXI4 memory-mapped interface. This is useful for
+ transferring data from a processor into the FPGA fabric. The driver creates
+ a character device that can be read/written to with standard
+ open/read/write/close.
+
+ See Xilinx PG080 document for IP details.
+
+ Currently supports only store-forward mode with a 32-bit AXI4-Lite
+ interface. DOES NOT support:
+ - cut-through mode
+ - AXI4 (non-lite)
+
+properties:
+ compatible:
+ enum:
+ - xlnx,axi-fifo-mm-s-4.1
+ - xlnx,axi-fifo-mm-s-4.2
+ - xlnx,axi-fifo-mm-s-4.3
+
+ interrupt-names:
+ const: interrupt
+
+ interrupts:
+ maxItems: 1
+
+ reg:
+ maxItems: 1
+
+ xlnx,axi-str-rxd-protocol:
+ $ref: /schemas/types.yaml#/definitions/string
+ const: XIL_AXI_STREAM_ETH_DATA
+ description: AXI4-Stream RX data protocol
+
+ xlnx,axi-str-rxd-tdata-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x20
+ description: AXI4-Stream RX data width
+
+ xlnx,axi-str-txc-protocol:
+ $ref: /schemas/types.yaml#/definitions/string
+ const: XIL_AXI_STREAM_ETH_CTRL
+ description: AXI4-Stream TX control protocol
+
+ xlnx,axi-str-txc-tdata-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x20
+ description: AXI4-Stream TX control data width
+
+ xlnx,axi-str-txd-protocol:
+ $ref: /schemas/types.yaml#/definitions/string
+ const: XIL_AXI_STREAM_ETH_DATA
+ description: AXI4-Stream TX data protocol
+
+ xlnx,axi-str-txd-tdata-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x20
+ description: AXI4-Stream TX data width
+
+ xlnx,axis-tdest-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: AXI-Stream TDEST width (ignored by the driver)
+
+ xlnx,axis-tid-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: AXI-Stream TID width (ignored by the driver)
+
+ xlnx,axis-tuser-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: AXI-Stream TUSER width (ignored by the driver)
+
+ xlnx,data-interface-type:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: ignored by the driver
+
+ xlnx,has-axis-tdest:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,has-axis-tid:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,has-axis-tkeep:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,has-axis-tstrb:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,has-axis-tuser:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,rx-fifo-depth:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Depth of RX FIFO in words
+
+ xlnx,rx-fifo-pe-threshold:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: RX programmable empty interrupt threshold
+ (ignored by the driver)
+
+ xlnx,rx-fifo-pf-threshold:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: RX programmable full interrupt threshold
+ (ignored by the driver)
+
+ xlnx,s-axi-id-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x4
+ description: ignored by the driver
+
+ xlnx,s-axi4-data-width:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x20
+ description: ignored by the driver
+
+ xlnx,select-xpm:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: ignored by the driver
+
+ xlnx,tx-fifo-depth:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Depth of TX FIFO in words
+
+ xlnx,tx-fifo-pe-threshold:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: TX programmable empty interrupt threshold
+ (ignored by the driver)
+
+ xlnx,tx-fifo-pf-threshold:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: TX programmable full interrupt threshold
+ (ignored by the driver)
+
+ xlnx,use-rx-cut-through:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,use-rx-data:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0x0, 0x1]
+ description: <0x1> if RX FIFO is enabled, <0x0> otherwise
+
+ xlnx,use-tx-ctrl:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,use-tx-cut-through:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0x0
+ description: this feature isn't supported
+
+ xlnx,use-tx-data:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0x0, 0x1]
+ description: <0x1> if TX FIFO is enabled, <0x0> otherwise
+
+required:
+ - compatible
+ - interrupt-names
+ - interrupts
+ - reg
+ - xlnx,axi-str-rxd-protocol
+ - xlnx,axi-str-rxd-tdata-width
+ - xlnx,axi-str-txc-protocol
+ - xlnx,axi-str-txc-tdata-width
+ - xlnx,axi-str-txd-protocol
+ - xlnx,axi-str-txd-tdata-width
+ - xlnx,axis-tdest-width
+ - xlnx,axis-tid-width
+ - xlnx,axis-tuser-width
+ - xlnx,data-interface-type
+ - xlnx,has-axis-tdest
+ - xlnx,has-axis-tid
+ - xlnx,has-axis-tkeep
+ - xlnx,has-axis-tstrb
+ - xlnx,has-axis-tuser
+ - xlnx,rx-fifo-depth
+ - xlnx,rx-fifo-pe-threshold
+ - xlnx,rx-fifo-pf-threshold
+ - xlnx,s-axi-id-width
+ - xlnx,s-axi4-data-width
+ - xlnx,select-xpm
+ - xlnx,tx-fifo-depth
+ - xlnx,tx-fifo-pe-threshold
+ - xlnx,tx-fifo-pf-threshold
+ - xlnx,use-rx-cut-through
+ - xlnx,use-rx-data
+ - xlnx,use-tx-ctrl
+ - xlnx,use-tx-cut-through
+ - xlnx,use-tx-data
+
+additionalProperties: false
+
+examples:
+ - |
+ axi_fifo_mm_s_0: axi_fifo_mm_s@43c00000 {
+ compatible = "xlnx,axi-fifo-mm-s-4.1";
+ interrupt-names = "interrupt";
+ interrupt-parent = <&intc>;
+ interrupts = <0 29 4>;
+ reg = <0x43c00000 0x10000>;
+ xlnx,axi-str-rxd-protocol = "XIL_AXI_STREAM_ETH_DATA";
+ xlnx,axi-str-rxd-tdata-width = <0x20>;
+ xlnx,axi-str-txc-protocol = "XIL_AXI_STREAM_ETH_CTRL";
+ xlnx,axi-str-txc-tdata-width = <0x20>;
+ xlnx,axi-str-txd-protocol = "XIL_AXI_STREAM_ETH_DATA";
+ xlnx,axi-str-txd-tdata-width = <0x20>;
+ xlnx,axis-tdest-width = <0x4>;
+ xlnx,axis-tid-width = <0x4>;
+ xlnx,axis-tuser-width = <0x4>;
+ xlnx,data-interface-type = <0x0>;
+ xlnx,has-axis-tdest = <0x0>;
+ xlnx,has-axis-tid = <0x0>;
+ xlnx,has-axis-tkeep = <0x0>;
+ xlnx,has-axis-tstrb = <0x0>;
+ xlnx,has-axis-tuser = <0x0>;
+ xlnx,rx-fifo-depth = <0x200>;
+ xlnx,rx-fifo-pe-threshold = <0x2>;
+ xlnx,rx-fifo-pf-threshold = <0x1fb>;
+ xlnx,s-axi-id-width = <0x4>;
+ xlnx,s-axi4-data-width = <0x20>;
+ xlnx,select-xpm = <0x0>;
+ xlnx,tx-fifo-depth = <0x8000>;
+ xlnx,tx-fifo-pe-threshold = <0x200>;
+ xlnx,tx-fifo-pf-threshold = <0x7ffb>;
+ xlnx,use-rx-cut-through = <0x0>;
+ xlnx,use-rx-data = <0x0>;
+ xlnx,use-tx-ctrl = <0x0>;
+ xlnx,use-tx-cut-through = <0x0>;
+ xlnx,use-tx-data = <0x1>;
+ };
+...
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] dt-bindings: axis-fifo: Added missing binding
2026-09-17 11:48 [PATCH v2] dt-bindings: axis-fifo: Added missing binding Daniel Matyas
@ 2026-09-17 11:58 ` Greg Kroah-Hartman
2026-09-17 15:09 ` Daniel Matyas
2026-09-17 18:24 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2026-09-17 11:58 UTC (permalink / raw)
To: Daniel Matyas
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Matyas,
linux-staging, devicetree, linux-kernel
On Thu, Sep 17, 2026 at 02:48:48PM +0300, Daniel Matyas wrote:
> From: Daniel Matyas <matyasdaniel005@gmail.com>
>
> drivers/staging/axis-fifo/axis-fifo.txt file described how the
> devicetree of the driver should look like. Convert it to .yaml file.
> Issue found by checkpatch.
>
> Signed-off-by: Daniel Matyas <matyasdaniel005@gmail.com>
> Signed-off-by: Daniel Matyas <matyasdaniel006@gmail.com>
Why twice?
> ---
>
> Sorry for adding another email. I got locked out of the first one for 30
> days...
>
> v2: Corrected syntax errors in compatible:
> xlnx,axis-fifo-mm-s-4.1 -> xlnx,axi-fifo-mm-s-4.1
> xlnx,axis-fifo-mm-s-4.2 -> xlnx,axi-fifo-mm-s-4.2
> xlnx,axis-fifo-mm-s-4.3 -> xlnx,axi-fifo-mm-s-4.3
>
> .../axis-fifo/xlnx,axi-fifo-mm-s.yaml | 257 ++++++++++++++++++
> 1 file changed, 257 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
staging drivers need to be stand-alone, in the drivers/staging/
directory, please keep these files there.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: axis-fifo: Added missing binding
2026-09-17 11:58 ` Greg Kroah-Hartman
@ 2026-09-17 15:09 ` Daniel Matyas
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Matyas @ 2026-09-17 15:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Daniel Matyas, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Daniel Matyas, linux-staging, devicetree, linux-kernel
On Thu, 17 Sep 2026 12:58:14 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Sep 17, 2026 at 02:48:48PM +0300, Daniel Matyas wrote:
> > From: Daniel Matyas <matyasdaniel005@gmail.com>
> >
> > drivers/staging/axis-fifo/axis-fifo.txt file described how the
> > devicetree of the driver should look like. Convert it to .yaml file.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Daniel Matyas <matyasdaniel005@gmail.com>
> > Signed-off-by: Daniel Matyas <matyasdaniel006@gmail.com>
>
> Why twice?
>
Lost access to the first email temporarily. Should I just remove the original email?
> > ---
> >
> > Sorry for adding another email. I got locked out of the first one for 30
> > days...
> >
> > v2: Corrected syntax errors in compatible:
> > xlnx,axis-fifo-mm-s-4.1 -> xlnx,axi-fifo-mm-s-4.1
> > xlnx,axis-fifo-mm-s-4.2 -> xlnx,axi-fifo-mm-s-4.2
> > xlnx,axis-fifo-mm-s-4.3 -> xlnx,axi-fifo-mm-s-4.3
> >
> > .../axis-fifo/xlnx,axi-fifo-mm-s.yaml | 257 ++++++++++++++++++
> > 1 file changed, 257 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
>
> staging drivers need to be stand-alone, in the drivers/staging/
> directory, please keep these files there.
>
> thanks,
>
> greg k-h
Does this mean that the staging drivers do not need a devicetree? Should I just
drop this patch entirely?
Thank you,
Daniel M
Sent using hkml (https://github.com/sjp38/hackermail)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: axis-fifo: Added missing binding
2026-09-17 11:48 [PATCH v2] dt-bindings: axis-fifo: Added missing binding Daniel Matyas
2026-09-17 11:58 ` Greg Kroah-Hartman
@ 2026-09-17 18:24 ` Krzysztof Kozlowski
2026-09-17 19:11 ` Daniel Matyas
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-17 18:24 UTC (permalink / raw)
To: Daniel Matyas, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Daniel Matyas
Cc: linux-staging, devicetree, linux-kernel
On 17/09/2026 13:48, Daniel Matyas wrote:
> From: Daniel Matyas <matyasdaniel005@gmail.com>
>
> drivers/staging/axis-fifo/axis-fifo.txt file described how the
> devicetree of the driver should look like. Convert it to .yaml file.
> Issue found by checkpatch.
>
> Signed-off-by: Daniel Matyas <matyasdaniel005@gmail.com>
> Signed-off-by: Daniel Matyas <matyasdaniel006@gmail.com>
> ---
>
> Sorry for adding another email. I got locked out of the first one for 30
I already you no and provided previous discussions giving the proper
reasons.
Why did you just ignore that?
NAK for this and any other future axis-fifo stuff like this.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: axis-fifo: Added missing binding
2026-09-17 18:24 ` Krzysztof Kozlowski
@ 2026-09-17 19:11 ` Daniel Matyas
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Matyas @ 2026-09-17 19:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Daniel Matyas, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Daniel Matyas, linux-staging,
devicetree, linux-kernel
On Thu, 17 Sep 2026 20:24:56 +0200 Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 17/09/2026 13:48, Daniel Matyas wrote:
> > From: Daniel Matyas <matyasdaniel005@gmail.com>
> >
> > drivers/staging/axis-fifo/axis-fifo.txt file described how the
> > devicetree of the driver should look like. Convert it to .yaml file.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Daniel Matyas <matyasdaniel005@gmail.com>
> > Signed-off-by: Daniel Matyas <matyasdaniel006@gmail.com>
> > ---
> >
> > Sorry for adding another email. I got locked out of the first one for 30
>
> I already you no and provided previous discussions giving the proper
> reasons.
>
> Why did you just ignore that?
>
> NAK for this and any other future axis-fifo stuff like this.
>
> Best regards,
> Krzysztof
I am sorry, I rushed with v2 without checking all the replies. I will pay
closer attention next time.
Thank you for pointing me to existing discussions about this conversion.
I will drop this patch.
Kind regards,
Daniel M
Sent using hkml (https://github.com/sjp38/hackermail)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-17 21:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 11:48 [PATCH v2] dt-bindings: axis-fifo: Added missing binding Daniel Matyas
2026-09-17 11:58 ` Greg Kroah-Hartman
2026-09-17 15:09 ` Daniel Matyas
2026-09-17 18:24 ` Krzysztof Kozlowski
2026-09-17 19:11 ` Daniel Matyas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®