From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Nicholas Miell <nmiell@comcast.net>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
linville@tuxdriver.com
Subject: Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.
Date: Mon, 22 Jan 2007 21:46:17 +1100 [thread overview]
Message-ID: <45B495F9.4@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0701211430020.17235@CPE00045a9c397f-CM001225dbafb6>
Robert P. J. Day wrote:
> by adding (temporarily) the definitions of TRUE and FALSE to types.h,
> you should then (theoretically) be able to delete over 100 instances
> of those same macros being *defined* throughout the source tree.
> you're not going to be deleting the hundreds and hundreds of *uses* of
> TRUE and FALSE (not yet, anyway) but, at the very least, by adding two
> lines to types.h, you can delete all those redundant *definitions* and
> make sure that nothing breaks. (it shouldn't, of course, but it's
> always nice to be sure.)
Doesn't seem very worthwhile, and it legitimises this definition we're
trying to get rid of.
> *now*, once that's done, you can start going through the tree and
> doing the conversion from upper case to lower case, little by little,
> subsystem by subsystem.
I don't see why your patch is needed before the individual conversions?
> the predictable response will be, "you really should do that all at
> once."
You don't need to do it all at once.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2007-01-22 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-21 10:03 Robert P. J. Day
2007-01-21 17:51 ` Nicholas Miell
2007-01-21 18:46 ` Richard Knutsson
2007-01-21 19:40 ` Robert P. J. Day
2007-01-22 10:46 ` Nick Piggin [this message]
2007-01-22 11:02 ` Robert P. J. Day
2007-01-22 12:00 ` Nick Piggin
2007-01-22 15:18 ` Mike Galbraith
2007-01-22 15:41 ` Robert P. J. Day
2007-01-22 16:52 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B495F9.4@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nmiell@comcast.net \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®