From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: stable@kernel.org
Cc: David Moore <dcm@MIT.EDU>,
linux-kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org, akpm@linux-foundation.org,
linux1394-devel <linux1394-devel@lists.sourceforge.net>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
Date: Sun, 04 Feb 2007 21:36:15 +0100 [thread overview]
Message-ID: <45C643BF.80204@s5r6.in-berlin.de> (raw)
In-Reply-To: <1170614380.26464.52.camel@PISCES.MIT.EDU>
David Moore wrote:
[...]
> considering the severity of this one-liner bug, I would like to
> request that this simplified patch make it into 2.6.20, despite how
> close we are to the final cut.
So we were too close. Maybe the -stable team likes to have it in 2.6.20.1.
> It fixes real crashes:
> http://lists.opensuse.org/opensuse-bugs/2006-12/msg02943.html
> http://qa.mandriva.com/show_bug.cgi?id=28224
> http://www.pchdtv.com/forum/viewtopic.php?t=2063&sid=a959a14a4c2db0eebaab7b0df56103ce
and FireWire crashes too.
> --- linux-2.6.19.x86_64/lib/swiotlb.c.orig 2007-02-04 13:18:41.000000000 -0500
> +++ linux-2.6.19.x86_64/lib/swiotlb.c 2007-02-04 13:19:43.000000000 -0500
> @@ -750,7 +750,7 @@ swiotlb_sync_sg(struct device *hwdev, st
>
> for (i = 0; i < nelems; i++, sg++)
> if (sg->dma_address != SG_ENT_PHYS_ADDRESS(sg))
> - sync_single(hwdev, (void *) sg->dma_address,
> + sync_single(hwdev, phys_to_virt(sg->dma_address),
> sg->dma_length, dir, target);
> }
>
--
Stefan Richter
-=====-=-=== --=- --=--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-02-04 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-04 18:39 David Moore
2007-02-04 20:36 ` Stefan Richter [this message]
2007-02-05 21:35 ` Andrew Morton
2007-02-06 7:56 ` Andi Kleen
2007-02-06 9:00 ` Stefan Richter
2007-02-06 9:08 ` Stefan Richter
2007-02-06 9:35 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C643BF.80204@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=dcm@MIT.EDU \
--cc=discuss@x86-64.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome