From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Moore <dcm@mit.edu>,
linux-kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org,
linux1394-devel <linux1394-devel@lists.sourceforge.net>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
Date: Tue, 06 Feb 2007 10:08:58 +0100 [thread overview]
Message-ID: <45C845AA.3010702@s5r6.in-berlin.de> (raw)
In-Reply-To: <45C84399.70407@s5r6.in-berlin.de>
I wrote:
> Unfortunately an author of lib/swiotlb.c chose to call many variables
> holding *virtual* addresses "dma_addr". Note how that file at the same
> time contains variables like "dma_addr_t dma_handle".
And there is even one occurrence of a "dma_addr" holding a physical
address/ bus address, unlike the other dma_addr's:
int
swiotlb_dma_mapping_error(dma_addr_t dma_addr)
{
return (dma_addr == virt_to_phys(io_tlb_overflow_buffer));
}
--
Stefan Richter
-=====-=-=== --=- --==-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-02-06 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-04 18:39 David Moore
2007-02-04 20:36 ` Stefan Richter
2007-02-05 21:35 ` Andrew Morton
2007-02-06 7:56 ` Andi Kleen
2007-02-06 9:00 ` Stefan Richter
2007-02-06 9:08 ` Stefan Richter [this message]
2007-02-06 9:35 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C845AA.3010702@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dcm@mit.edu \
--cc=discuss@x86-64.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®