* [for-next][PATCH] tracing: Add missing "inline" in stub function of latency_fsnotify()
@ 2019-11-15 13:27 Steven Rostedt
2019-11-15 13:46 ` Viktor Rosendahl
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2019-11-15 13:27 UTC (permalink / raw)
To: LKML
Cc: Ingo Molnar, Stephen Rothwell, Viktor Rosendahl (BMW),
Joel Fernandes (Google)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The latency_fsnotify() stub when the function is not defined, was missing
the "inline".
Link: https://lore.kernel.org/r/20191115140213.74c5efe7@canb.auug.org.au
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 90cba68c8b50..2df8aed6a8f0 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -801,7 +801,7 @@ void latency_fsnotify(struct trace_array *tr);
#else
-static void latency_fsnotify(struct trace_array *tr) { }
+static inline void latency_fsnotify(struct trace_array *tr) { }
#endif
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [for-next][PATCH] tracing: Add missing "inline" in stub function of latency_fsnotify()
2019-11-15 13:27 [for-next][PATCH] tracing: Add missing "inline" in stub function of latency_fsnotify() Steven Rostedt
@ 2019-11-15 13:46 ` Viktor Rosendahl
0 siblings, 0 replies; 2+ messages in thread
From: Viktor Rosendahl @ 2019-11-15 13:46 UTC (permalink / raw)
To: Steven Rostedt, LKML
Cc: Ingo Molnar, Stephen Rothwell, Joel Fernandes (Google)
On 11/15/19 2:27 PM, Steven Rostedt wrote:
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 90cba68c8b50..2df8aed6a8f0 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -801,7 +801,7 @@ void latency_fsnotify(struct trace_array *tr);
>
> #else
>
> -static void latency_fsnotify(struct trace_array *tr) { }
> +static inline void latency_fsnotify(struct trace_array *tr) { }
>
> #endif
>
>
Looks good to me.
Thanks for fixing this.
best regards,
Viktor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 13:27 [for-next][PATCH] tracing: Add missing "inline" in stub function of latency_fsnotify() Steven Rostedt
2019-11-15 13:46 ` Viktor Rosendahl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®