From: Chao Yu <chao@kernel.org>
To: Wu Bo <bo.wu@vivo.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, wubo.oduw@gmail.com
Subject: Re: [PATCH 1/1] f2fs: pass I_NEW flag to trace event
Date: Wed, 17 May 2023 10:44:43 +0800 [thread overview]
Message-ID: <45eb63c6-a147-776a-99b5-7ac06848ede8@kernel.org> (raw)
In-Reply-To: <20230516120747.68844-1-bo.wu@vivo.com>
On 2023/5/16 20:07, Wu Bo wrote:
> Modify the order between 'trace_f2fs_iget' & 'unlock_new_inode', so the
> I_NEW can pass to the trace event when the inode initialised.
Why is it needed? And trace_f2fs_iget() won't print inode->i_state?
Thanks,
>
> Signed-off-by: Wu Bo <bo.wu@vivo.com>
> ---
> fs/f2fs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index cf4327ad106c..caf959289fe7 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -577,8 +577,8 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino)
> file_dont_truncate(inode);
> }
>
> - unlock_new_inode(inode);
> trace_f2fs_iget(inode);
> + unlock_new_inode(inode);
> return inode;
>
> bad_inode:
next prev parent reply other threads:[~2023-05-17 2:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 12:07 Wu Bo
2023-05-17 2:44 ` Chao Yu [this message]
2023-05-17 3:59 ` [f2fs-dev] " Wu Bo
2023-05-17 8:36 ` Chao Yu
2023-05-17 14:31 ` Wu Bo
2023-05-18 0:32 ` Jaegeuk Kim
2023-05-18 15:02 ` Wu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45eb63c6-a147-776a-99b5-7ac06848ede8@kernel.org \
--to=chao@kernel.org \
--cc=bo.wu@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wubo.oduw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®