* [PATCH] nvme-fabrics: Use seq_putc() in __nvmf_concat_opt_tokens()
@ 2024-07-13 13:50 Markus Elfring
2024-07-15 20:50 ` Keith Busch
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2024-07-13 13:50 UTC (permalink / raw)
To: linux-nvme, kernel-janitors, Christoph Hellwig, Jens Axboe,
Keith Busch, Sagi Grimberg
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 13 Jul 2024 15:43:17 +0200
Single characters should be put into a sequence.
Thus use the corresponding function “seq_putc”.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/nvme/host/fabrics.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 44e342a46f39..f5f545fa0103 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -1403,10 +1403,10 @@ static void __nvmf_concat_opt_tokens(struct seq_file *seq_file)
tok = &opt_tokens[idx];
if (tok->token == NVMF_OPT_ERR)
continue;
- seq_puts(seq_file, ",");
+ seq_putc(seq_file, ',');
seq_puts(seq_file, tok->pattern);
}
- seq_puts(seq_file, "\n");
+ seq_putc(seq_file, '\n');
}
static int nvmf_dev_show(struct seq_file *seq_file, void *private)
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-fabrics: Use seq_putc() in __nvmf_concat_opt_tokens()
2024-07-13 13:50 [PATCH] nvme-fabrics: Use seq_putc() in __nvmf_concat_opt_tokens() Markus Elfring
@ 2024-07-15 20:50 ` Keith Busch
0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2024-07-15 20:50 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-nvme, kernel-janitors, Christoph Hellwig, Jens Axboe,
Sagi Grimberg, LKML
On Sat, Jul 13, 2024 at 03:50:24PM +0200, Markus Elfring wrote:
> Single characters should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was transformed by using the Coccinelle software.
Thanks, applied to nvme-6.11.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-15 20:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-13 13:50 [PATCH] nvme-fabrics: Use seq_putc() in __nvmf_concat_opt_tokens() Markus Elfring
2024-07-15 20:50 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®