From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Antonio Terceiro <antonio.terceiro@linaro.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros
Date: Fri, 12 Mar 2021 07:30:48 -0800 [thread overview]
Message-ID: <4609846ceedc24505dcaaba40933abb8b3e577e1.camel@linux.intel.com> (raw)
In-Reply-To: <20210312135746.1695294-1-antonio.terceiro@linaro.org>
On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote:
> These macros introduce nondeterminism in builds, and break
> reproducible
> builds.
Thanks. I will include this change in my pull request.
-Srinivas
>
> Signed-off-by: Antonio Terceiro <antonio.terceiro@linaro.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> tools/power/x86/intel-speed-select/isst-config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> b/tools/power/x86/intel-speed-select/isst-config.c
> index 582feb88eca3..c50c754a656e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -2791,7 +2791,6 @@ static void usage(void)
> static void print_version(void)
> {
> fprintf(outf, "Version %s\n", version_str);
> - fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
> exit(0);
> }
>
prev parent reply other threads:[~2021-03-12 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:57 Antonio Terceiro
2021-03-12 15:30 ` Srinivas Pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4609846ceedc24505dcaaba40933abb8b3e577e1.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=antonio.terceiro@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome