* [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros
@ 2021-03-12 13:57 Antonio Terceiro
2021-03-12 15:30 ` Srinivas Pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Terceiro @ 2021-03-12 13:57 UTC (permalink / raw)
To: platform-driver-x86, linux-kernel; +Cc: Srinivas Pandruvada
These macros introduce nondeterminism in builds, and break reproducible
builds.
Signed-off-by: Antonio Terceiro <antonio.terceiro@linaro.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
tools/power/x86/intel-speed-select/isst-config.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c
index 582feb88eca3..c50c754a656e 100644
--- a/tools/power/x86/intel-speed-select/isst-config.c
+++ b/tools/power/x86/intel-speed-select/isst-config.c
@@ -2791,7 +2791,6 @@ static void usage(void)
static void print_version(void)
{
fprintf(outf, "Version %s\n", version_str);
- fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
exit(0);
}
--
2.30.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros
2021-03-12 13:57 [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros Antonio Terceiro
@ 2021-03-12 15:30 ` Srinivas Pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Pandruvada @ 2021-03-12 15:30 UTC (permalink / raw)
To: Antonio Terceiro, platform-driver-x86, linux-kernel
On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote:
> These macros introduce nondeterminism in builds, and break
> reproducible
> builds.
Thanks. I will include this change in my pull request.
-Srinivas
>
> Signed-off-by: Antonio Terceiro <antonio.terceiro@linaro.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> tools/power/x86/intel-speed-select/isst-config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> b/tools/power/x86/intel-speed-select/isst-config.c
> index 582feb88eca3..c50c754a656e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -2791,7 +2791,6 @@ static void usage(void)
> static void print_version(void)
> {
> fprintf(outf, "Version %s\n", version_str);
> - fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
> exit(0);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-12 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 13:57 [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros Antonio Terceiro
2021-03-12 15:30 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome