From: K Prateek Nayak <kprateek.nayak@amd.com>
To: fangqiurong <fangqiurong@kylinos.cn>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Remove dead throttled check in pick_task_fair()
Date: Wed, 5 Aug 2026 14:42:23 +0530 [thread overview]
Message-ID: <4613455c-8e26-4746-9dc9-c2e3d793244e@amd.com> (raw)
In-Reply-To: <20260805013949.151089-1-fangqiurong@kylinos.cn>
On 8/5/2026 7:09 AM, fangqiurong wrote:
> commit f666241e6bd5 ("sched/fair: Unify cfs_rq throttling via
> account_cfs_rq_runtime()") removed the only assignment to @throttled in
> the pick_task_fair() walk loop, making the variable and the trailing
> task_throttle_setup_work() call dead code. Drop them.
Thank you for catching my oversight. Looking at tip:sched/core,
Peter has already cleaned this up as a part of commit 85570f10a4c6
("sched/eevdf: Move to a single runqueue")
--
Thanks and Regards,
Prateek
prev parent reply other threads:[~2026-08-05 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 1:39 fangqiurong
2026-08-05 9:12 ` K Prateek Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4613455c-8e26-4746-9dc9-c2e3d793244e@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fangqiurong@kylinos.cn \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®