From: "Jan Beulich" <jbeulich@novell.com>
To: "Haruo Tomita" <haruo.tomita@toshiba.co.jp>
Cc: <prarit@redhat.com>, "lkml" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1
Date: Thu, 26 Apr 2007 07:36:36 +0100 [thread overview]
Message-ID: <46306494.76E4.0078.0@novell.com> (raw)
In-Reply-To: <BF571719A4041A478005EF3F08EA6DF004332397@pcsmail03.pcs.pc.ome.toshiba.co.jp>
But why do you remove the printk()?
>>> "Tomita, Haruo" <haruo.tomita@toshiba.co.jp> 26.04.07 08:27 >>>
This patch fixes a typo in mod_init().
fwh_done is performed when Intel fwh is found.
intel-rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c~ 2007-04-26 13:41:53.000000000 +0900
+++ linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c 2007-04-26 13:43:35.000000000 +0900
@@ -264,7 +264,6 @@ static int __init intel_rng_hw_init(void
if (mfc != INTEL_FWH_MANUFACTURER_CODE ||
(dvc != INTEL_FWH_DEVICE_CODE_8M &&
dvc != INTEL_FWH_DEVICE_CODE_4M)) {
- printk(KERN_ERR PFX "FWH not detected\n");
return -ENODEV;
}
@@ -365,7 +364,8 @@ static int __init mod_init(void)
pci_dev_put(dev);
iounmap(intel_rng_hw->mem);
kfree(intel_rng_hw);
- goto out;
+ if (err)
+ goto out;
fwh_done:
err = -ENOMEM;
prev parent reply other threads:[~2007-04-26 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 6:27 Tomita, Haruo
2007-04-26 6:36 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46306494.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=haruo.tomita@toshiba.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®