* [PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1
@ 2007-04-26 6:27 Tomita, Haruo
2007-04-26 6:36 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Tomita, Haruo @ 2007-04-26 6:27 UTC (permalink / raw)
To: prarit, jbeulich; +Cc: lkml, Tomita, Haruo
This patch fixes a typo in mod_init().
fwh_done is performed when Intel fwh is found.
intel-rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c~ 2007-04-26 13:41:53.000000000 +0900
+++ linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c 2007-04-26 13:43:35.000000000 +0900
@@ -264,7 +264,6 @@ static int __init intel_rng_hw_init(void
if (mfc != INTEL_FWH_MANUFACTURER_CODE ||
(dvc != INTEL_FWH_DEVICE_CODE_8M &&
dvc != INTEL_FWH_DEVICE_CODE_4M)) {
- printk(KERN_ERR PFX "FWH not detected\n");
return -ENODEV;
}
@@ -365,7 +364,8 @@ static int __init mod_init(void)
pci_dev_put(dev);
iounmap(intel_rng_hw->mem);
kfree(intel_rng_hw);
- goto out;
+ if (err)
+ goto out;
fwh_done:
err = -ENOMEM;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1
2007-04-26 6:27 [PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1 Tomita, Haruo
@ 2007-04-26 6:36 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2007-04-26 6:36 UTC (permalink / raw)
To: Haruo Tomita; +Cc: prarit, lkml
But why do you remove the printk()?
>>> "Tomita, Haruo" <haruo.tomita@toshiba.co.jp> 26.04.07 08:27 >>>
This patch fixes a typo in mod_init().
fwh_done is performed when Intel fwh is found.
intel-rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c~ 2007-04-26 13:41:53.000000000 +0900
+++ linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c 2007-04-26 13:43:35.000000000 +0900
@@ -264,7 +264,6 @@ static int __init intel_rng_hw_init(void
if (mfc != INTEL_FWH_MANUFACTURER_CODE ||
(dvc != INTEL_FWH_DEVICE_CODE_8M &&
dvc != INTEL_FWH_DEVICE_CODE_4M)) {
- printk(KERN_ERR PFX "FWH not detected\n");
return -ENODEV;
}
@@ -365,7 +364,8 @@ static int __init mod_init(void)
pci_dev_put(dev);
iounmap(intel_rng_hw->mem);
kfree(intel_rng_hw);
- goto out;
+ if (err)
+ goto out;
fwh_done:
err = -ENOMEM;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-26 6:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-26 6:27 [PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1 Tomita, Haruo
2007-04-26 6:36 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®