From: Rik van Riel <riel@surriel.com>
To: Jianyong Wu <wujianyong@hygon.cn>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, jianyong.wu@outlook.com
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: Correct misleading comment in task_numa_migrate()
Date: Mon, 08 Sep 2025 12:25:49 -0400 [thread overview]
Message-ID: <46380ec48c4d2e2d01a229650129066bb3d6c329.camel@surriel.com> (raw)
In-Reply-To: <20250908061923.543081-1-wujianyong@hygon.cn>
On Mon, 2025-09-08 at 14:19 +0800, Jianyong Wu wrote:
> The current comment implies that both the task and the group must get
> benefit for a node to be considered. However, the actual code allows
> a node to pass if *either* the task *or* the group meets the
> criteria.
>
> As established in the previous discussion [1], the code logic is
> correct.
> Update the comment to accurately reflect that either condition is
> sufficient.
>
> Signed-off-by: Jianyong Wu <wujianyong@hygon.cn>
Reviewed-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
next prev parent reply other threads:[~2025-09-08 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 6:19 Jianyong Wu
2025-09-08 16:25 ` Rik van Riel [this message]
2025-09-26 11:59 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46380ec48c4d2e2d01a229650129066bb3d6c329.camel@surriel.com \
--to=riel@surriel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jianyong.wu@outlook.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wujianyong@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®