From: Jianyong Wu <wujianyong@hygon.cn>
To: "mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
Rik van Riel <riel@surriel.com>
Cc: "dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"vschneid@redhat.com" <vschneid@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jianyong.wu@outlook.com" <jianyong.wu@outlook.com>
Subject: RE: [PATCH] sched/fair: Correct misleading comment in task_numa_migrate()
Date: Fri, 26 Sep 2025 11:59:58 +0000 [thread overview]
Message-ID: <8c88ffd5e9de4a4cb56068c506e0cdbf@hygon.cn> (raw)
In-Reply-To: <46380ec48c4d2e2d01a229650129066bb3d6c329.camel@surriel.com>
Hi Peter, Rik, and maintainers,
Gentle ping on this small comment fix patch.
It was reviewed by Rik about 3 weeks ago and got a " Reviewed-by" [1]. Since then there has been no further comments. I just wonder if there are any other concerns or if it is ready to be picked up.
The original patch is here:
[1] https://lore.kernel.org/lkml/20250908061923.543081-1-wujianyong@hygon.cn/
Thanks for your time.
Best regards,
Jianyong Wu
Jianyong Wu> -----Original Message-----
> From: Rik van Riel <riel@surriel.com>
> Sent: Tuesday, September 9, 2025 12:26 AM
> To: Jianyong Wu <wujianyong@hygon.cn>; mingo@redhat.com;
> peterz@infradead.org; juri.lelli@redhat.com; vincent.guittot@linaro.org;
> jianyong.wu@outlook.com
> Cc: dietmar.eggemann@arm.com; rostedt@goodmis.org; bsegall@google.com;
> mgorman@suse.de; vschneid@redhat.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] sched/fair: Correct misleading comment in
> task_numa_migrate()
>
> On Mon, 2025-09-08 at 14:19 +0800, Jianyong Wu wrote:
> > The current comment implies that both the task and the group must get
> > benefit for a node to be considered. However, the actual code allows a
> > node to pass if *either* the task *or* the group meets the criteria.
> >
> > As established in the previous discussion [1], the code logic is
> > correct.
> > Update the comment to accurately reflect that either condition is
> > sufficient.
> >
> > Signed-off-by: Jianyong Wu <wujianyong@hygon.cn>
>
> Reviewed-by: Rik van Riel <riel@surriel.com>
>
> --
> All Rights Reversed.
prev parent reply other threads:[~2025-09-26 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 6:19 Jianyong Wu
2025-09-08 16:25 ` Rik van Riel
2025-09-26 11:59 ` Jianyong Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c88ffd5e9de4a4cb56068c506e0cdbf@hygon.cn \
--to=wujianyong@hygon.cn \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jianyong.wu@outlook.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®