* [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource()
@ 2025-10-29 13:47 Geert Uytterhoeven
2025-10-29 15:00 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-10-29 13:47 UTC (permalink / raw)
To: Frank Binns, Matt Coster, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Sarah Walker,
Donald Robson
Cc: dri-devel, linux-kernel, Geert Uytterhoeven
The call to devm_platform_ioremap_resource() was replaced by a call to
devm_platform_get_and_ioremap_resource(), but the comment referring to
the function's possible returned error codes was not updated.
Fixes: 927f3e0253c11276 ("drm/imagination: Implement MIPS firmware processor and MMU support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/imagination/pvr_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c
index 294b6019b4155bb7..78d6b8a0a4506c80 100644
--- a/drivers/gpu/drm/imagination/pvr_device.c
+++ b/drivers/gpu/drm/imagination/pvr_device.c
@@ -48,7 +48,7 @@
*
* Return:
* * 0 on success, or
- * * Any error returned by devm_platform_ioremap_resource().
+ * * Any error returned by devm_platform_get_and_ioremap_resource().
*/
static int
pvr_device_reg_init(struct pvr_device *pvr_dev)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource()
2025-10-29 13:47 [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource() Geert Uytterhoeven
@ 2025-10-29 15:00 ` Geert Uytterhoeven
2025-10-30 12:12 ` Matt Coster
2025-10-31 14:42 ` Matt Coster
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-10-29 15:00 UTC (permalink / raw)
To: Frank Binns, Matt Coster, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Sarah Walker,
Donald Robson
Cc: dri-devel, linux-kernel, Geert Uytterhoeven
The call to devm_platform_ioremap_resource() was replaced by a call to
devm_platform_get_and_ioremap_resource(), but the comment referring to
the function's possible returned error codes was not updated.
Fixes: 927f3e0253c11276 ("drm/imagination: Implement MIPS firmware processor and MMU support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/imagination/pvr_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c
index 294b6019b4155bb7..78d6b8a0a4506c80 100644
--- a/drivers/gpu/drm/imagination/pvr_device.c
+++ b/drivers/gpu/drm/imagination/pvr_device.c
@@ -48,7 +48,7 @@
*
* Return:
* * 0 on success, or
- * * Any error returned by devm_platform_ioremap_resource().
+ * * Any error returned by devm_platform_get_and_ioremap_resource().
*/
static int
pvr_device_reg_init(struct pvr_device *pvr_dev)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource()
2025-10-29 13:47 [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource() Geert Uytterhoeven
2025-10-29 15:00 ` Geert Uytterhoeven
@ 2025-10-30 12:12 ` Matt Coster
2025-10-31 14:42 ` Matt Coster
2 siblings, 0 replies; 4+ messages in thread
From: Matt Coster @ 2025-10-30 12:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Frank Binns, Alessio Belle, Alexandru Dadu, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1276 bytes --]
Hi Geert,
On 29/10/2025 15:00, Geert Uytterhoeven wrote:
> The call to devm_platform_ioremap_resource() was replaced by a call to
> devm_platform_get_and_ioremap_resource(), but the comment referring to
> the function's possible returned error codes was not updated.
>
> Fixes: 927f3e0253c11276 ("drm/imagination: Implement MIPS firmware processor and MMU support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks for the fix!
Reviewed-by: Matt Coster <matt.coster@imgtec.com>
I'll apply this to drm-misc-fixes shortly.
Cheers,
Matt
> ---
> drivers/gpu/drm/imagination/pvr_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c
> index 294b6019b4155bb7..78d6b8a0a4506c80 100644
> --- a/drivers/gpu/drm/imagination/pvr_device.c
> +++ b/drivers/gpu/drm/imagination/pvr_device.c
> @@ -48,7 +48,7 @@
> *
> * Return:
> * * 0 on success, or
> - * * Any error returned by devm_platform_ioremap_resource().
> + * * Any error returned by devm_platform_get_and_ioremap_resource().
> */
> static int
> pvr_device_reg_init(struct pvr_device *pvr_dev)
--
Matt Coster
E: matt.coster@imgtec.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource()
2025-10-29 13:47 [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource() Geert Uytterhoeven
2025-10-29 15:00 ` Geert Uytterhoeven
2025-10-30 12:12 ` Matt Coster
@ 2025-10-31 14:42 ` Matt Coster
2 siblings, 0 replies; 4+ messages in thread
From: Matt Coster @ 2025-10-31 14:42 UTC (permalink / raw)
To: Frank Binns, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Sarah Walker, Donald Robson,
Geert Uytterhoeven
Cc: dri-devel, linux-kernel
On Wed, 29 Oct 2025 16:00:28 +0100, Geert Uytterhoeven wrote:
> The call to devm_platform_ioremap_resource() was replaced by a call to
> devm_platform_get_and_ioremap_resource(), but the comment referring to
> the function's possible returned error codes was not updated.
>
>
Applied, thanks!
[1/1] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource()
commit: f1aa93005d0d6fb3293ca9c3eb08d1d1557117bf
Best regards,
--
Matt Coster <matt.coster@imgtec.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-31 14:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-29 13:47 [PATCH] drm/imagination: Fix reference to devm_platform_get_and_ioremap_resource() Geert Uytterhoeven
2025-10-29 15:00 ` Geert Uytterhoeven
2025-10-30 12:12 ` Matt Coster
2025-10-31 14:42 ` Matt Coster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®