* [PATCH] watchdog: lenovo_se10_wdt: Convert comma to semicolon
@ 2024-07-16 3:07 Chen Ni
2024-07-16 5:29 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Chen Ni @ 2024-07-16 3:07 UTC (permalink / raw)
To: wim, linux, mpearson-lenovo, dober; +Cc: linux-watchdog, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Fixes: 1f6602c8ed1e ("watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/watchdog/lenovo_se10_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/lenovo_se10_wdt.c b/drivers/watchdog/lenovo_se10_wdt.c
index 139ff0e8220f..cd0500e5080b 100644
--- a/drivers/watchdog/lenovo_se10_wdt.c
+++ b/drivers/watchdog/lenovo_se10_wdt.c
@@ -196,8 +196,8 @@ static int se10_wdt_probe(struct platform_device *pdev)
watchdog_set_drvdata(&priv->wdd, priv);
priv->wdd.parent = dev;
- priv->wdd.info = &wdt_info,
- priv->wdd.ops = &se10_wdt_ops,
+ priv->wdd.info = &wdt_info;
+ priv->wdd.ops = &se10_wdt_ops;
priv->wdd.timeout = WATCHDOG_TIMEOUT; /* Set default timeout */
priv->wdd.min_timeout = MIN_TIMEOUT;
priv->wdd.max_timeout = MAX_TIMEOUT;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: lenovo_se10_wdt: Convert comma to semicolon
2024-07-16 3:07 [PATCH] watchdog: lenovo_se10_wdt: Convert comma to semicolon Chen Ni
@ 2024-07-16 5:29 ` Guenter Roeck
2024-07-16 14:23 ` Mark Pearson
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2024-07-16 5:29 UTC (permalink / raw)
To: Chen Ni, wim, mpearson-lenovo, dober; +Cc: linux-watchdog, linux-kernel
On 7/15/24 20:07, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 1f6602c8ed1e ("watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: lenovo_se10_wdt: Convert comma to semicolon
2024-07-16 5:29 ` Guenter Roeck
@ 2024-07-16 14:23 ` Mark Pearson
0 siblings, 0 replies; 3+ messages in thread
From: Mark Pearson @ 2024-07-16 14:23 UTC (permalink / raw)
To: Guenter Roeck, Chen Ni, Wim Van Sebroeck, David Ober
Cc: linux-watchdog, linux-kernel
Hi Chen,
Thank you for fixing this - I should have caught this originally :(
I'm slightly bemused that it worked at all.
On Tue, Jul 16, 2024, at 1:29 AM, Guenter Roeck wrote:
> On 7/15/24 20:07, Chen Ni wrote:
>> Replace a comma between expression statements by a semicolon.
>>
>> Fixes: 1f6602c8ed1e ("watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform")
>> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-16 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-16 3:07 [PATCH] watchdog: lenovo_se10_wdt: Convert comma to semicolon Chen Ni
2024-07-16 5:29 ` Guenter Roeck
2024-07-16 14:23 ` Mark Pearson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®