From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: dts: qcom: msm8960: drop spi-max-frequency from controller
Date: Mon, 19 Jun 2023 19:16:18 +0200 [thread overview]
Message-ID: <4658b5c2-3140-2071-391f-1f8af722aa53@linaro.org> (raw)
In-Reply-To: <20230619170151.65505-4-krzysztof.kozlowski@linaro.org>
On 19.06.2023 19:01, Krzysztof Kozlowski wrote:
> spi-max-frequency is a property of SPI device, not SPI controller. Drop
> it from the controller nodes. No functional impact expected, although
> qcom-msm8960-samsung-expressatt board does not have any child SPI
> devices thus the property disappears. This fixes dtbs_check warnings
> like:
>
> qcom-msm8960-cdp.dtb: spi@16080000: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-msm8960.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index fa2013388d99..d13080fcbeea 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -364,7 +364,6 @@ gsbi1_spi: spi@16080000 {
> #size-cells = <0>;
> reg = <0x16080000 0x1000>;
> interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> - spi-max-frequency = <24000000>;
> cs-gpios = <&msmgpio 8 0>;
>
> clocks = <&gcc GSBI1_QUP_CLK>, <&gcc GSBI1_H_CLK>;
next prev parent reply other threads:[~2023-06-19 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 17:01 [PATCH 1/4] ARM: dts: qcom: ipq4019: use generic node names for USB Krzysztof Kozlowski
2023-06-19 17:01 ` [PATCH 2/4] ARM: dts: qcom: sdx55: " Krzysztof Kozlowski
2023-06-19 17:15 ` Konrad Dybcio
2023-06-19 17:01 ` [PATCH 3/4] ARM: dts: qcom: ipq8064: drop spi-max-frequency from controller Krzysztof Kozlowski
2023-06-19 17:16 ` Konrad Dybcio
2023-06-19 17:01 ` [PATCH 4/4] ARM: dts: qcom: msm8960: " Krzysztof Kozlowski
2023-06-19 17:16 ` Konrad Dybcio [this message]
2023-06-19 17:15 ` [PATCH 1/4] ARM: dts: qcom: ipq4019: use generic node names for USB Konrad Dybcio
2023-07-10 5:07 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4658b5c2-3140-2071-391f-1f8af722aa53@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®