mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: dts: qcom: ipq8064: drop spi-max-frequency from controller
Date: Mon, 19 Jun 2023 19:16:02 +0200	[thread overview]
Message-ID: <c542a678-fbbb-35ca-d286-34fc3926cbcb@linaro.org> (raw)
In-Reply-To: <20230619170151.65505-3-krzysztof.kozlowski@linaro.org>

On 19.06.2023 19:01, Krzysztof Kozlowski wrote:
> spi-max-frequency is a property of SPI device, not SPI controller.  Drop
> it from the controller nodes.  No functional impact expected because
> child SPI device already defines spi-max-frequency.  This fixes
> dtbs_check warnings like:
> 
>   qcom-ipq8064-ap148.dtb: spi@1a280000: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 1 -
>  arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 104eb729c2d6..1796ded31d17 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -282,7 +282,6 @@ gsbi5: gsbi@1a200000 {
>  
>  			spi4: spi@1a280000 {
>  				status = "okay";
> -				spi-max-frequency = <50000000>;
>  
>  				pinctrl-0 = <&spi_pins>;
>  				pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> index c5abe7151f14..17f65e140e02 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> @@ -30,7 +30,6 @@ gsbi5: gsbi@1a200000 {
>  
>  			spi4: spi@1a280000 {
>  				status = "okay";
> -				spi-max-frequency = <50000000>;
>  
>  				pinctrl-0 = <&spi_pins>;
>  				pinctrl-names = "default";

  reply	other threads:[~2023-06-19 17:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 17:01 [PATCH 1/4] ARM: dts: qcom: ipq4019: use generic node names for USB Krzysztof Kozlowski
2023-06-19 17:01 ` [PATCH 2/4] ARM: dts: qcom: sdx55: " Krzysztof Kozlowski
2023-06-19 17:15   ` Konrad Dybcio
2023-06-19 17:01 ` [PATCH 3/4] ARM: dts: qcom: ipq8064: drop spi-max-frequency from controller Krzysztof Kozlowski
2023-06-19 17:16   ` Konrad Dybcio [this message]
2023-06-19 17:01 ` [PATCH 4/4] ARM: dts: qcom: msm8960: " Krzysztof Kozlowski
2023-06-19 17:16   ` Konrad Dybcio
2023-06-19 17:15 ` [PATCH 1/4] ARM: dts: qcom: ipq4019: use generic node names for USB Konrad Dybcio
2023-07-10  5:07 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c542a678-fbbb-35ca-d286-34fc3926cbcb@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®